feat(event): enhance FrameworkEventInitType type definition #2171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 770eacb The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
AndrejNikolicEq
approved these changes
May 22, 2024
The FrameworkEventInitType type definition has been enhanced to support both IFrameworkEvent and FrameworkEvent generic types. This change improves type safety and flexibility when working with framework events. Additionally, the FrameworkEventInitType type has been exported from the event module, making it more accessible for other parts of the codebase.
odinr
force-pushed
the
feat/event/improve-event-typeings
branch
from
c5c64f6
to
770eacb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This PR introduces changes to the
FrameworkEventInitTypeutility type in the@equinor/fusion-frameworkpackage. The current behavior is that theFrameworkEventInitTypetype only handles events that extend theIFrameworkEventinterface. The new behavior is that it also handles events that extend theFrameworkEventclass.This change does not introduce a breaking change, as it only extends the functionality of the existing
FrameworkEventInitTypetype.closes: N/A (no issue referenced)
Check off the following:
Confirm that I checked changes to branch which I am merging into.
Confirm that the I have completed the self-review checklist.
Confirm that my changes meet our code of conduct.