Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(react-framework): update possible null and undefined #1766

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

odinr
Copy link
Collaborator

@odinr odinr commented Jan 31, 2024

Why

improve handling of possible null and undefined

Check off the following:

  • Confirm that I checked changes to branch which I am merging into.

    • I have validated included files
    • My code does not generate new linting warnings
    • My PR is not a duplicate, check existing pr`s
  • Confirm that the I have completed the self-review checklist.

  • Confirm that my changes meet our code of conduct.

Conditional

  • Confirm project selected and category, actual, iteration are set
  • Confirm Milestone selected (if any)

Copy link

changeset-bot bot commented Jan 31, 2024

🦋 Changeset detected

Latest commit: a99ade8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@equinor/fusion-framework-react Patch
@equinor/fusion-framework-cli Patch
@equinor/fusion-framework-react-app Patch
@equinor/fusion-framework-react-components-bookmark Patch
@equinor/fusion-framework-react-components-people-provider Patch
@equinor/fusion-framework-legacy-interopt Patch
@equinor/fusion-framework-react-module-bookmark Patch
@equinor/fusion-framework-cookbook-app-react-feature-flag Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@odinr odinr force-pushed the fix/react-framework/enhance-possible-null-or-undefined branch from 7adf297 to a99ade8 Compare January 31, 2024 15:13
@odinr odinr marked this pull request as ready for review January 31, 2024 15:13
@odinr odinr requested a review from a team as a code owner January 31, 2024 15:13
@odinr odinr self-assigned this Jan 31, 2024
@odinr odinr enabled auto-merge (squash) January 31, 2024 15:15
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 4.8% 1288 / 26792
🔵 Statements 4.8% 1288 / 26792
🔵 Functions 5.99% 41 / 684
🔵 Branches 14.52% 106 / 730
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/react/framework/src/app/useCurrentApp.ts 0% 0% 0% 0% 1-38
packages/react/framework/src/app/useCurrentAppModule.ts 0% 0% 0% 0% 1-45
packages/react/framework/src/app/useCurrentAppModules.ts 0% 0% 0% 0% 1-44
Generated in workflow #3867

@odinr odinr merged commit fdbe12f into main Jan 31, 2024
10 of 11 checks passed
@odinr odinr deleted the fix/react-framework/enhance-possible-null-or-undefined branch January 31, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants