Feat/cli/personsidesheet #1635

eikeland · 2023-12-20T15:45:54Z

adding sidebar feature toggler in cli header.
See the cli package for the PersonSideSheet component.

Issue, The hook does not get app features only portal features.

Fixes: AB#46155

changeset-bot · 2023-12-20T15:45:58Z

🦋 Changeset detected

Latest commit: 27a4440

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages

Name	Type
@equinor/fusion-framework-cookbook-app-react-feature-flag	Patch
@equinor/fusion-framework-module-feature-flag	Patch
@equinor/fusion-framework-cookbook-app-react	Patch
@equinor/fusion-framework-react-app	Patch
@equinor/fusion-framework-cli	Patch
@equinor/fusion-framework-react	Patch
@equinor/fusion-framework-legacy-interopt	Patch
@equinor/fusion-framework-react-components-bookmark	Patch
@equinor/fusion-framework-react-components-people-provider	Patch
@equinor/fusion-framework-react-module-bookmark	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2023-12-20T15:48:35Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	73.11%	1273 / 1741
🔵	Statements	73.11%	1273 / 1741
🔵	Functions	51.35%	38 / 74
🔵	Branches	85.24%	104 / 122

File Coverage

No changed files found.

Generated in workflow #3282

packages/cli/src/bin/dev-portal/PersonSideSheet/index.tsx

packages/modules/feature-flag/src/plugins/cgi/plugin.ts

- commenting out the feature api plugin so the app will work oob - using the getFeatureFlags to list all app features

…v and peer dep

packages/react/app/src/feature-flag/useFeatureFlags.ts

packages/react/framework/src/feature-flag/useFeatureFlags.ts

packages/react/app/src/feature-flag/useFeatureFlags.ts

packages/react/framework/src/feature-flag/useFeatureFlags.ts

odinr · 2024-01-11T12:10:51Z

packages/cli/src/bin/dev-portal/Header.tsx

+    const azureId: string | undefined = useMemo(() => {
+        if (currentUser) {
+            return currentUser.localAccountId;
+        }
+    }, [currentUser]);


Suggested change

const azureId: string | undefined = useMemo(() => {

if (currentUser) {

return currentUser.localAccountId;

}

}, [currentUser]);

const azureId = currentUser?.localAccountId

no need to memorized

odinr · 2024-01-11T12:14:57Z

packages/cli/src/bin/dev-portal/PersonSideSheet/sheets/RoleSheetContent.tsx

why do we have this?
in the future this will be a widget

odinr

i think we should remove unused code

* chore(useFeatureFlags): adding hook for getting all feature flags * feat(cli): adding personsidesheet with feature flags * chore(package): supporting new node versions * chore(cli): commenting out for test * chore: lockfile * chore(feature-flag): fixing useFeatureFlags hook * docs: changeset * chore: lint errors * chore(node): only support latest LTS node version * feat(featuretoggler): adds hook for getting useCurrentAppFeatureFlags * feat(cli-feature): personsidesheet uses hook useCurrentAppFeatureFlags * chore(react-app): unnessesary export of internal helper function * chore(cookbook): adapting cookbook to new featureflag hooks. - commenting out the feature api plugin so the app will work oob - using the getFeatureFlags to list all app features * chore(cli): styles for switches in featuretoggler sidesheet * docs(tsdocs): tsdocs for hook useCurrentAppFeatureFlags * docs(tsdocs): tsdocs for hook useFeatureFlags * fix(feature-flag): add missing arrow_back icon * fix(cli): enable feature flag cgi module plugin * fix(feature-flag): add testing flags for app and portal * fix(feature-flag): update localStorage name for cookbook and cli * style(app-react-feature-flag): fix lint errors * docs(feature-flag): add docs for feature-flag * fix(feature-flag): hook useFrameworkFeatureFlag moved to fusion-framework-react/app * docs(feature-flag): move docs from module to guide * fix: simplify configurator * fix(cookbook|cli): update to use simplified configurator for feature flag * docs(feature-flag): update to use simplified configurator for feature flag * fix(feature-flag): remove unused imports * chore(framework-feature-flag): moving feature-flag hoooks to own folder * chore(cli-feature-flag): new framework feature-flag hook location * chore(cli): removing obsolete dependency * chore(react-app): @equinor/fusion-framework-module-feature-flag as dev and peer dep * chore(react-app): feature-flag hook refractoring * docs(module-feature-flag): readme meeting notes * chore(pnpm): lockfile * fix(eslint): minor linting in featue-flag hooks * docs(feature-flag): readme completet done task * fix(cli): remove unneded useMemo for azureId * fix(cli): removing unused sidesheet tabs --------- Co-authored-by: Asbjørn Håland <[email protected]> Co-authored-by: Odin Thomas Rochmann <[email protected]>

eikeland requested review from odinr and a team as code owners December 20, 2023 15:45

eikeland requested a review from asbjornhaland December 20, 2023 15:46

github-actions bot added 👾 React 💾 CLI fusion framework CLI 🚀 feature New feature or request 🚧 chore maintaines work, (update deps, workflos ...) labels Dec 20, 2023

eikeland self-assigned this Dec 20, 2023

github-actions bot added the 📚 documentation Improvements or additions to documentation label Dec 20, 2023

github-actions bot reviewed Dec 20, 2023

View reviewed changes

packages/cli/src/bin/dev-portal/PersonSideSheet/index.tsx Outdated Show resolved Hide resolved

github-actions bot added the 🧬 Modules label Dec 20, 2023

github-actions bot reviewed Dec 20, 2023

View reviewed changes

packages/cli/src/bin/dev-portal/PersonSideSheet/index.tsx Show resolved Hide resolved

packages/modules/feature-flag/src/plugins/cgi/plugin.ts Show resolved Hide resolved

asbjornhaland marked this pull request as draft January 2, 2024 09:24

asbjornhaland marked this pull request as ready for review January 2, 2024 09:24

github-actions bot added the 👨🏻‍🍳 cookbooks label Jan 4, 2024

eikeland added 13 commits January 5, 2024 15:00

chore(useFeatureFlags): adding hook for getting all feature flags

a28c31d

feat(cli): adding personsidesheet with feature flags

e680672

chore(package): supporting new node versions

ce99987

chore(cli): commenting out for test

2047003

chore: lockfile

a449af0

chore(feature-flag): fixing useFeatureFlags hook

d3ee210

docs: changeset

1fa6117

chore: lint errors

e2989fc

chore(node): only support latest LTS node version

db39284

feat(featuretoggler): adds hook for getting useCurrentAppFeatureFlags

d3a5f2c

feat(cli-feature): personsidesheet uses hook useCurrentAppFeatureFlags

d1d08d6

chore(react-app): unnessesary export of internal helper function

3d19bad

chore(cookbook): adapting cookbook to new featureflag hooks.

1bcaf91

- commenting out the feature api plugin so the app will work oob - using the getFeatureFlags to list all app features

eikeland added 7 commits January 10, 2024 16:24

chore(framework-feature-flag): moving feature-flag hoooks to own folder

75d8915

chore(cli-feature-flag): new framework feature-flag hook location

03810e6

chore(cli): removing obsolete dependency

8fc8bc3

chore(react-app): @equinor/fusion-framework-module-feature-flag as de…

89f1663

…v and peer dep

chore(react-app): feature-flag hook refractoring

0deddac

docs(module-feature-flag): readme meeting notes

ee8a637

chore(pnpm): lockfile

5f66c0c

eikeland requested a review from odinr January 10, 2024 15:28

eikeland marked this pull request as ready for review January 11, 2024 08:51

github-actions bot reviewed Jan 11, 2024

View reviewed changes

eikeland added 2 commits January 11, 2024 10:00

fix(eslint): minor linting in featue-flag hooks

adcb212

docs(feature-flag): readme completet done task

da2a883

github-actions bot reviewed Jan 11, 2024

View reviewed changes

eikeland marked this pull request as draft January 11, 2024 09:11

eikeland marked this pull request as ready for review January 11, 2024 09:11

odinr reviewed Jan 11, 2024

View reviewed changes

odinr requested changes Jan 11, 2024

View reviewed changes

github-actions bot marked this pull request as draft January 11, 2024 12:18

eikeland added 2 commits January 11, 2024 13:20

fix(cli): remove unneded useMemo for azureId

dbb3305

fix(cli): removing unused sidesheet tabs

27a4440

eikeland marked this pull request as ready for review January 11, 2024 12:25

odinr approved these changes Jan 11, 2024

View reviewed changes

odinr merged commit 1c091dd into feature/feature-flag/initial Jan 11, 2024
11 checks passed

odinr deleted the feat/cli/personsidesheet branch January 11, 2024 12:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/cli/personsidesheet #1635

Feat/cli/personsidesheet #1635

eikeland commented Dec 20, 2023 •

edited

Loading

changeset-bot bot commented Dec 20, 2023 •

edited

Loading

github-actions bot commented Dec 20, 2023 •

edited

Loading

odinr Jan 11, 2024

eikeland Jan 11, 2024

odinr Jan 11, 2024

eikeland Jan 11, 2024

odinr left a comment

Feat/cli/personsidesheet #1635

Feat/cli/personsidesheet #1635

Conversation

eikeland commented Dec 20, 2023 • edited Loading

changeset-bot bot commented Dec 20, 2023 • edited Loading

🦋 Changeset detected

github-actions bot commented Dec 20, 2023 • edited Loading

Coverage Report

odinr Jan 11, 2024

Choose a reason for hiding this comment

eikeland Jan 11, 2024

Choose a reason for hiding this comment

odinr Jan 11, 2024

Choose a reason for hiding this comment

eikeland Jan 11, 2024

Choose a reason for hiding this comment

odinr left a comment

Choose a reason for hiding this comment

eikeland commented Dec 20, 2023 •

edited

Loading

changeset-bot bot commented Dec 20, 2023 •

edited

Loading

github-actions bot commented Dec 20, 2023 •

edited

Loading