Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module-navigation): check previous state #1467

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

odinr
Copy link
Collaborator

@odinr odinr commented Oct 27, 2023

check previous state before dispatching push and replace.

partially rolls back #1453 since no longer needs master & slave

Why

closes:

Check off the following:

  • Confirm that I checked changes to branch which I am merging into.

    • I have validated included files
    • My code does not generate new linting warnings
    • My PR is not a duplicate, check existing pr`s
  • Confirm that the I have completed the self-review checklist.

  • Confirm that my changes meet our code of conduct.

Conditional

  • Confirm project selected and category, actual, iteration are set
  • Confirm Milestone selected (if any)

@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2023

🦋 Changeset detected

Latest commit: 7090d88

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@equinor/fusion-framework-module-navigation Patch
@equinor/fusion-framework-cli Patch
@equinor/fusion-framework-react-app Patch
@equinor/fusion-framework-legacy-interopt Patch
@equinor/fusion-framework-react-module-bookmark Patch
@equinor/fusion-framework-cookbook-app-react-people Patch
@equinor/fusion-framework Patch
@equinor/fusion-framework-react-module-context Patch
@equinor/fusion-framework-react-components-bookmark Patch
@equinor/fusion-framework-react-components-people-provider Patch
@equinor/fusion-framework-app Patch
@equinor/fusion-framework-react Patch
@equinor/fusion-framework-widget Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 🐞 bug Something isn't working 🧬 Modules labels Oct 27, 2023
@odinr odinr marked this pull request as ready for review October 27, 2023 13:14
@odinr odinr requested a review from a team as a code owner October 27, 2023 13:14
@github-actions
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 73.11% 1273 / 1741
🔵 Statements 73.11% 1273 / 1741
🔵 Functions 51.35% 38 / 74
🔵 Branches 85.24% 104 / 122
File CoverageNo changed files found.
Generated in workflow #1978

@odinr odinr merged commit a8f0f06 into main Oct 30, 2023
12 checks passed
@odinr odinr deleted the fix/navigation/duplicate-locations branch October 30, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 🧬 Modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant