Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module-services): add people api #1243

Merged
merged 2 commits into from
Sep 8, 2023
Merged

feat(module-services): add people api #1243

merged 2 commits into from
Sep 8, 2023

Conversation

odinr
Copy link
Collaborator

@odinr odinr commented Sep 8, 2023

initial people service

Why

initial api implementations of people service

this module is meant for internal usage

lacking documentation, but not meant for consumption outside 'core' functionality

closes:

Check off the following:

  • Confirm that I checked changes to branch which I am merging into.

    • I have validated included files
    • My code does not generate new linting warnings
    • My PR is not a duplicate, check existing pr`s
  • Confirm that the I have completed the self-review checklist.

  • Confirm that my changes meet our code of conduct.

Conditional

  • Confirm project selected and category, actual, iteration are set
  • Confirm Milestone selected (if any)

@odinr odinr self-assigned this Sep 8, 2023
@changeset-bot
Copy link

changeset-bot bot commented Sep 8, 2023

🦋 Changeset detected

Latest commit: 6c11f18

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@equinor/fusion-framework-module-services Minor
@equinor/fusion-framework-cli Patch
@equinor/fusion-framework Patch
@equinor/fusion-framework-app Patch
@equinor/fusion-framework-react Patch
@equinor/fusion-framework-legacy-interopt Patch
@equinor/fusion-framework-widget Patch
@equinor/fusion-framework-react-components-bookmark Patch
@equinor/fusion-framework-react-module-bookmark Patch
@equinor/fusion-framework-react-module-context Patch
@equinor/fusion-framework-react-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 🚀 feature New feature or request 🧬 Modules labels Sep 8, 2023
@odinr odinr marked this pull request as ready for review September 8, 2023 10:17
@odinr odinr requested a review from a team as a code owner September 8, 2023 10:17
packages/modules/services/src/provider.ts Outdated Show resolved Hide resolved
packages/modules/services/src/types.ts Outdated Show resolved Hide resolved
@equinor equinor deleted a comment from github-actions bot Sep 8, 2023
@equinor equinor deleted a comment from github-actions bot Sep 8, 2023
@equinor equinor deleted a comment from github-actions bot Sep 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 57.71% 374 / 648
🔵 Statements 57.71% 374 / 648
🔵 Functions 26.31% 5 / 19
🔵 Branches 84.21% 16 / 19
File CoverageNo changed files found.
Generated in workflow #872

@odinr odinr merged commit f277c7f into main Sep 8, 2023
3 checks passed
@odinr odinr deleted the feat/services/people branch September 8, 2023 10:35
@odinr odinr added this to the Person milestone Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 feature New feature or request 🧬 Modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants