fix: update FUSION_LOG_LEVEL configuration in vite config generation (#…

…2107)
equinor · Apr 29, 2024 · 491c2e0 · 491c2e0
1 parent 1d6ca2e
commit 491c2e0
Show file tree

Hide file tree

Showing 5 changed files with 38 additions and 14 deletions.
diff --git a/.changeset/tricky-carpets-rush.md b/.changeset/tricky-carpets-rush.md
@@ -0,0 +1,11 @@
+---
+"@equinor/fusion-query": patch
+"@equinor/fusion-framework-cli": patch
+---
+
+Fixed issue with missing process env `FUSION_LOG_LEVEL`
+
+- added default resolve value when generating base vite configuration
+- moved default query log level resolve outside class
+
+fixes: https://github.com/equinor/fusion/issues/343
diff --git a/packages/cli/src/lib/vite-config.ts b/packages/cli/src/lib/vite-config.ts
@@ -87,6 +87,8 @@ export const createViteConfig = async (
             tsconfigPaths(),
             viteEnv({
                 NODE_ENV: env.mode,
+                FUSION_LOG_LEVEL:
+                    process.env.FUSION_LOG_LEVEL ?? env.mode === 'development' ? '3' : '1',
             }),
         ],
         root,

diff --git a/packages/cli/vite.config.ts b/packages/cli/vite.config.ts
@@ -13,10 +13,5 @@ export default defineConfig({
     build: {
         outDir: fileURLToPath(new URL('./dist/bin/public', import.meta.url)),
         emptyOutDir: true,
-        // minify: false,
-        // terserOptions: {
-            //     mangle: false,
-        // },
     },
-    // mode: 'development',
 });
diff --git a/packages/utils/query/README.md b/packages/utils/query/README.md
@@ -187,6 +187,22 @@ subscription.unsubscribe();
 query.complete();
 ```
 
+## Setup
+
+When compiling code the `FUSION_LOG_LEVEL` must be set (depending on build util, example shown for Vite)
+
+`Uncaught ReferenceError: process is not defined`
+
+```ts
+defineConfig({
+    plugins: [
+        tsconfigPaths(),
+        viteEnv({
+            FUSION_LOG_LEVEL: process.env.FUSION_LOG_LEVEL ?? process.env.NODE_ENV === 'development' ? '3' : '1'
+        }),
+    ]
+})
+
 ## Advanced Usage
 
 ### Queue Operators

diff --git a/packages/utils/query/src/logger.ts b/packages/utils/query/src/logger.ts
@@ -43,9 +43,15 @@ export interface ILogger {
     createSubLogger(domain: string): ILogger;
 }
 
+const defaultLogLevel = process.env.FUSION_LOG_LEVEL
+    ? (Number(process.env.FUSION_LOG_LEVEL) as 0 | 1 | 2 | 3 | 4)
+    : process.env.NODE_ENV === 'development'
+      ? 3
+      : 1;
+
 export class ConsoleLogger implements ILogger {
-    /** - 0-1-2-3 (error-warning-info-debug) if not provided only errors are logged */
-    public level: 0 | 1 | 2 | 3 | 4;
+    /** - 0-1-2-3 (off-error-warning-info-debug) if not provided only errors are logged */
+    public level: 0 | 1 | 2 | 3 | 4 = defaultLogLevel;
 
     /**
      * Constructs a new ConsoleLogger instance.
@@ -55,13 +61,7 @@ export class ConsoleLogger implements ILogger {
     constructor(
         protected title: string,
         protected subtitle?: string,
-    ) {
-        if (process.env.FUSION_LOG_LEVEL) {
-            this.level = parseInt(process.env.FUSION_LOG_LEVEL) as 0 | 1 | 2 | 3 | 4;
-        } else {
-            this.level = process.env.NODE_ENV === 'development' ? 3 : 1;
-        }
-    }
+    ) {}
 
     /**
      * Generates the formatted message to log, including the title, subtitle (if any), and the messages provided.