fix(cli): resolving code review issues

equinor · Oct 2, 2024 · 07f584b · 07f584b
1 parent 6ff6662
commit 07f584b
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/packages/cli/src/bin/utils/getEndpointUrl.ts b/packages/cli/src/bin/utils/getEndpointUrl.ts
@@ -27,7 +27,7 @@ export const getEndpointUrl = async (
         process.env.FUSION_CLI_ENV = fusionEnv;
 
         const requestService = await fetch(
-            `https://discovery.ci.fusion-dev.net/service-registry/environments/${fusionEnv}/services/apps`,
+            `https://discovery.fusion.equinor.com/service-registry/environments/${fusionEnv}/services/apps`,
             {
                 headers: {
                     Authorization: `Bearer ${FUSION_TOKEN}`,

diff --git a/packages/cli/src/bin/utils/publishAppConfig.ts b/packages/cli/src/bin/utils/publishAppConfig.ts
@@ -21,13 +21,13 @@ export const publishAppConfig = async (endpoint: string, appKey: string, config:
         throw new Error(
             `App ${appKey} is deleted from apps-service. HTTP status ${requestConfig.status}, ${requestConfig.statusText}`,
         );
-    } else if (!requestConfig.ok || requestConfig.status > 399) {
+    } else if (!requestConfig.ok || requestConfig.status >= 400) {
         const response = await requestConfig.json();
         console.log(response);
         throw new Error(
             `Failed to upload config. HTTP status ${requestConfig.status}, ${requestConfig.statusText}`,
         );
     }
 
-    return await requestConfig.json();
+    return requestConfig.json();
 };
diff --git a/packages/cli/src/bin/utils/tagAppBundle.ts b/packages/cli/src/bin/utils/tagAppBundle.ts
@@ -28,5 +28,5 @@ export const tagAppBundle = async (endpoint: string, version: string) => {
         );
     }
 
-    return await requestTag.json();
+    return requestTag.json();
 };
diff --git a/packages/cli/src/bin/utils/uploadAppBundle.ts b/packages/cli/src/bin/utils/uploadAppBundle.ts
@@ -54,5 +54,5 @@ export const uploadAppBundle = async (endpoint: string, bundle: string) => {
         );
     }
 
-    return await requestBundle.json();
+    return requestBundle.json();
 };