Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support workday manager structure #721

Merged
merged 28 commits into from
Nov 20, 2024
Merged

feat: Support workday manager structure #721

merged 28 commits into from
Nov 20, 2024

Conversation

HansDahle
Copy link
Collaborator

  • New feature
  • Bug fix
  • High impact

Description of work:
Managers structure is changed when workday is rolled out. The manager will no longer be in the department he/she is maanger for. This means they are moved one level up.

Logics we have where isResourceOwner is combined with fullDepartment cannot be used as is.

Testing:

  • Can be tested
  • Automatic tests created / updated
  • Local tests are passing

TBD, tests must be refactored as setup for manager structure will be more complex

Checklist:

  • Considered automated tests
  • Considered updating specification / documentation
  • Considered work items
  • Considered security
  • Performed developer testing
  • Checklist finalized / ready for review

@HansDahle
Updated claimstransformer to add claims based on roles instead of pro…
8be5cd4 
…file and resource owner flag.
@HansDahle
Updated claimstransformer to add claims based on roles instead of pro…
9c067db 
…file and resource owner flag.
@HansDahle
refactored
a3e4099
@HansDahle
Changed auth to new requirement
fd8c069
@HansDahle
WIP manager test setup
8b7d166
@HansDahle
Merge branch 'feat/workday-manager-structure-support' of https://gith…
c70b1cc 
…ub.com/equinor/fusion-app-resources into feat/workday-manager-structure-support
@HansDahle
Fixed security matrix tests
7e52f32
@HansDahle
Updated tests to construct manager correctly
20684ad
@HansDahle
Fixed tests, refactored how manager for departments is fetched
15e923a
@HansDahle
Fixed tests by fixing mocking setup
b0713da
@HansDahle
Fixed tests
690ccaf
@HansDahle
Fixed & refactored tests
6c57fd0
@HansDahle
Changed test department to avoid collision
d7e3057
@HansDahle
Added support for emulate access
575d890
@HansDahle
Added options with emulate to personnel
ad6f4c0
@HansDahle
Fixed duplicate options endpoint
24e42bf
@HansDahle
Fixed endpoint not working due to combination and required params
66197c5
@HansDahle
Merge remote-tracking branch 'origin/master' into feat/workday-manage…
5600feb 
…r-structure-support
@HansDahle
Fixed incorrect options endpoint
2f586d9
@HansDahle
Added tll to pr deploy
5f39732
@HansDahle
Fixed incorrect auth check
ac1053d
@HansDahle
Updated old auth usage
2b7247b
@HansDahle
Fixed response when not allowed to emulate user
30297f1
@HansDahle HansDahle marked this pull request as ready for review November 15, 2024 12:56
HansDahle
HansDahle commented Nov 15, 2024
View reviewed changes
Copy link
Collaborator Author

@HansDahle HansDahle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some context around changes made

src/backend/Fusion.Resources.Authorization/IAuthorizationRequirementExtensions.cs Show resolved Hide resolved
src/backend/Fusion.Resources.Authorization/Requirements/ResourceOwnerRequirement.cs Outdated Show resolved Hide resolved
src/backend/api/Fusion.Resources.Api/Authorization/Extensions/RequirementsBuilderExtensions.cs Show resolved Hide resolved
src/backend/api/Fusion.Resources.Api/Controllers/Filter/EmulatedUserSupport.cs Show resolved Hide resolved
src/backend/api/Fusion.Resources.Api/Controllers/Personnel/InternalPersonnelController.cs Show resolved Hide resolved
src/backend/api/Fusion.Resources.Api/Controllers/Requests/DepartmentRequestsController.cs Show resolved Hide resolved
src/backend/api/Fusion.Resources.Api/Deployment/k8s/pr-deployment-env.yml Show resolved Hide resolved
src/backend/tests/Fusion.Resources.Api.Tests/Fixture/ResourceApiFixture.cs Show resolved Hide resolved
src/backend/tests/Fusion.Resources.Api.Tests/IntegrationTests/DepartmentRequestsTests.cs Show resolved Hide resolved
@HansDahle
Copy link
Collaborator Author

Can be tested @

OPTIONS https://fra-resources-721.pr.api.fusion-dev.net/departments/PDP PRD PMC PCA PCA1/resources/[email protected]

OPTIONS https://fra-resources-721.pr.api.fusion-dev.net/departments/TDI OG FOS FOIT PDL/resources/[email protected]

... other options endpoints

Must activate role FullControl to be able to emulate user.

Jonathanio123
Jonathanio123 reviewed Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@Jonathanio123 Jonathanio123 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments. Does this PR have a connected work item in DevOps? To keep track of its release

src/backend/api/Fusion.Resources.Api/Authentication/ResourcesLocalClaimsTransformation.cs Outdated Show resolved Hide resolved
src/backend/Fusion.Resources.Authorization/Requirements/ResourceOwnerRequirement.cs Outdated Show resolved Hide resolved
src/backend/api/Fusion.Resources.Api/Controllers/Requests/DepartmentRequestsController.cs Show resolved Hide resolved
src/backend/tests/Fusion.Testing.Mocks.ProfileService/PeopleServiceMock.cs Show resolved Hide resolved
@HansDahle HansDahle merged commit 687eac1 into master Nov 20, 2024
13 checks passed
@HansDahle HansDahle deleted the feat/workday-manager-structure-support branch November 20, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larfeq larfeq larfeq left review comments

@Jonathanio123 Jonathanio123 Jonathanio123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HansDahle @Jonathanio123 @larfeq