feat/filter out product positions from GetDepartmentPersonnel #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work:
We don't want product positions (instances) to show up in the list over all allocations in Personnel Allocation, and therefore we need to filter out all these positions.
AB#55286
AB#53017
Testing:
Can be tested with using endpoint:
https://resources-api-pr-671.fusion-dev.net/departments/{departmentString}/resources/personnel?api-version=2.0
Change departmentString with the department you want to check. Example "PDP PRD PMC PCA PCA4".
PDP PRD PMC PCA PCA4 should have a person that are assigned to a positions instance with baseposition of type "Project". This should not be shown in the result here
Should not get any product (instances) of type Product when getting DepartmentPersonnel. Should still give all the other positions
Checklist:
Considered updating specification / documentation