Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for grids and grid properties #355

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rwiker
Copy link
Contributor

@rwiker rwiker commented Nov 25, 2024

Issue

N/A

Short description

  • adds class CPGrid
  • adds class CPGridProperty
  • adds accessors grids and grid_properties to class SearchContext (similar to existing accessors surfaces, tables, etc.)

Pre-review checklist

  • Read through all changes. No redundant print() statements, commented-out code, or other remnants from the development. 👀
  • Make sure tests pass after every commit. ✅
  • New/refactored code is following same conventions as the rest of the code base. 🧬
  • New/refactored code is tested. ⚙
  • Documentation has been updated 🧾

Pre-merge checklist

  • Commit history is consistent and clean. 👌

@rwiker rwiker requested a review from a team November 25, 2024 09:09
@perolavsvendsen
Copy link
Member

I see zero tests (in the PR), but possibly not relevant and/or already there?

@rwiker
Copy link
Contributor Author

rwiker commented Nov 25, 2024 via email

…ases, .iterations and .realizations in the process.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants