Always sim2sumo #210
Merged
Always sim2sumo #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adnejacobsen
approved these changes
Sep 19, 2023
daniel-sol
force-pushed
the
always_sim2sumo
branch
from
b85fa84
to
bfd3b78
Compare
Default is now arrow, so we need tests for the oposite
Compdat with complump raises this error
When running it can be usefull to upfront see what will be run
daniel-sol
force-pushed
the
always_sim2sumo
branch
from
bfd3b78
to
e3f7210
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change code for sim2sumo utility such that no section sim2sumo in config file give upload of some standard types from simulator. These are for the time being summary, rft, and relative permeability (aka satfunc in sim2sumo speak)
With this change all the user wil have to do is add FORWARD_MODEL SIM2SUMO, and he or she will imedeately start uploading simulator results to sumo.
Also defaults to uploading arrow files, now user will have to specify arrow: false to not use arrow, then it changes to csv files