Add ecl2df as utility #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But not all, not functioning properly
daniel-sol
requested review from
perolavsvendsen,
ovejorgensen and
adnejacobsen
| upload_with_config(args.config_path, args.env) | ||
|
|
||
|
|
||
| # @hook_implementation |
There was a problem hiding this comment.
Intentionally left in the code?
There was a problem hiding this comment.
Some small comments here and there, but some more fundamental questions:
- Has this been tested with e.g. Drogon or other functional FMU workflows using a komodo environment (e.g. do we know that the job installs and works?)
- As commented in the code, not all fields use the conventional output for global_variables. Is it possible to provide a custom path?
…nto add_ecl2df_as_utility
adnejacobsen
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving #197. But suggesting that utility should be called sim2sumo.
*Add metadata to export of csv files with library ecl2df