Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement robot specific stop button #1799

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Implement robot specific stop button #1799

wants to merge 4 commits into from

Conversation

haakonsf
Copy link
Contributor

@haakonsf haakonsf commented Nov 19, 2024 •
edited
Loading

Closes #1779

@haakonsf haakonsf force-pushed the add-stop-button-to-robot-cards branch from 52cf4fc to c59c02a Compare November 20, 2024 09:40
@haakonsf haakonsf marked this pull request as ready for review November 20, 2024 09:46
@haakonsf haakonsf changed the title Implement functionality for unconditional stop Implement robot specific stop button Nov 20, 2024
@haakonsf
Copy link
Contributor Author

Dependent on equinor/isar#634

@haakonsf haakonsf force-pushed the add-stop-button-to-robot-cards branch from c59c02a to 5bddb70 Compare November 20, 2024 13:23
andchiind
andchiind approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haakonsf haakonsf force-pushed the add-stop-button-to-robot-cards branch from 4589011 to 692a987 Compare November 25, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andchiind andchiind andchiind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add stop button on robot cards
2 participants
@haakonsf @andchiind