-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix _storage_main terminate_on_parent_death
not working on mac
#9110
base: main
Are you sure you want to change the base?
Conversation
adaf604
to
2d26299
Compare
2d26299
to
91e15dc
Compare
terminate_on_parent_death
not working on mac
91e15dc
to
8bc64be
Compare
@JHolba Will outsourcing the parent-proccess-"living-situation"-polling to a new thread cause issues? This is the best thing chatgpt and I came up with. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9110 +/- ##
=======================================
Coverage 90.69% 90.70%
=======================================
Files 349 350 +1
Lines 21764 21787 +23
=======================================
+ Hits 19738 19761 +23
Misses 2026 2026
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
225d82e
to
bb80e7a
Compare
69c07b0
to
09fdd16
Compare
09fdd16
to
85b7774
Compare
77a83ac
to
440d10c
Compare
Prior to this commit, the `terminate_on_parent_death` function was only usable on linux, due to it using the prctl command. This commit creates a new thread which polls the parent process, and signals terminate when it can no longer find the parent.
440d10c
to
4f18e23
Compare
Prior to this commit, the
terminate_on_parent_death
function was only usable on linux, due to it using the prctl command. This commit creates a new thread which polls the parent process, and signals terminate when it can no longer find the parent.Issue
Resolves #8452
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"'
)When applicable