Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use only get_ensemble_state to check for existing responses/parameters #9047

Merged
merged 6 commits into from
Nov 25, 2024

Conversation

yngve-sk
Copy link
Contributor

@yngve-sk yngve-sk commented Oct 25, 2024

(also one step closer to statemap)

Removes duplication of looped calls to _responses_exist_for_realization, _parameters_exist_for_realization, which are now only called from within one place. Makes it easier to add a global state to them when they are invoked for all reals.

Return set of RealizationStorageState from get_ensemble_state() and show accordingly in GUI:
Screenshot 2024-10-28 at 09 42 19

Screenshot 2024-10-28 at 09 42 57

@yngve-sk yngve-sk marked this pull request as draft October 25, 2024 08:00
@yngve-sk yngve-sk force-pushed the 24.10.25.use-only-ensemble-state branch 7 times, most recently from bcf4075 to e0bb2ed Compare October 28, 2024 12:00
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 93.61702% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.60%. Comparing base (9817d75) to head (e0a9e1e).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/ert/storage/local_ensemble.py 90.90% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9047      +/-   ##
==========================================
- Coverage   90.70%   90.60%   -0.10%     
==========================================
  Files         349      349              
  Lines       21776    21786      +10     
==========================================
- Hits        19751    19739      -12     
- Misses       2025     2047      +22     
Flag Coverage Δ
cli-tests 38.82% <74.46%> (-0.17%) ⬇️
gui-tests 71.70% <93.61%> (-0.01%) ⬇️
performance-tests 49.27% <74.46%> (+0.02%) ⬆️
unit-tests 79.52% <76.59%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yngve-sk yngve-sk force-pushed the 24.10.25.use-only-ensemble-state branch 2 times, most recently from 9ca041c to e0a9e1e Compare October 28, 2024 12:45
@yngve-sk yngve-sk marked this pull request as ready for review October 28, 2024 14:12
@yngve-sk yngve-sk changed the title Dedupe some state checking logic Cache get_ensemble_state() Oct 28, 2024
@yngve-sk yngve-sk self-assigned this Nov 12, 2024
@yngve-sk yngve-sk force-pushed the 24.10.25.use-only-ensemble-state branch 4 times, most recently from 3c9b47c to 0d76ce2 Compare November 15, 2024 07:11
Copy link
Collaborator

@oyvindeide oyvindeide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you just do the final rebase and get it ready for merge?

src/ert/storage/local_ensemble.py Show resolved Hide resolved
@yngve-sk yngve-sk force-pushed the 24.10.25.use-only-ensemble-state branch 3 times, most recently from 5679c63 to bf90f33 Compare November 20, 2024 08:25
Copy link
Collaborator

@oyvindeide oyvindeide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you make the PR title a little more descriptive though? And remember to add a label

@yngve-sk yngve-sk added the release-notes:skip If there should be no mention of this in release notes label Nov 20, 2024
@yngve-sk yngve-sk changed the title Cache get_ensemble_state() Use only get_ensemble_state to check for existing responses/parameters Nov 20, 2024
@yngve-sk yngve-sk force-pushed the 24.10.25.use-only-ensemble-state branch from bf90f33 to d8812b5 Compare November 20, 2024 10:35
@yngve-sk yngve-sk force-pushed the 24.10.25.use-only-ensemble-state branch 8 times, most recently from 2e1a65a to f0dac84 Compare November 25, 2024 08:33
@yngve-sk yngve-sk force-pushed the 24.10.25.use-only-ensemble-state branch from f0dac84 to 4894c58 Compare November 25, 2024 09:54
@yngve-sk yngve-sk merged commit fe9926b into equinor:main Nov 25, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants