-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use only get_ensemble_state to check for existing responses/parameters #9047
Use only get_ensemble_state to check for existing responses/parameters #9047
Conversation
bcf4075
to
e0bb2ed
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9047 +/- ##
==========================================
- Coverage 90.70% 90.60% -0.10%
==========================================
Files 349 349
Lines 21776 21786 +10
==========================================
- Hits 19751 19739 -12
- Misses 2025 2047 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9ca041c
to
e0a9e1e
Compare
3c9b47c
to
0d76ce2
Compare
d77cf17
to
b6ed75b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, can you just do the final rebase and get it ready for merge?
5679c63
to
bf90f33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Can you make the PR title a little more descriptive though? And remember to add a label
bf90f33
to
d8812b5
Compare
2e1a65a
to
f0dac84
Compare
f0dac84
to
4894c58
Compare
(also one step closer to statemap)
Removes duplication of looped calls to
_responses_exist_for_realization
,_parameters_exist_for_realization
, which are now only called from within one place. Makes it easier to add a global state to them when they are invoked for all reals.Return set of
RealizationStorageState
fromget_ensemble_state()
and show accordingly in GUI: