Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug intel macs #8881

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented Oct 4, 2024

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.97%. Comparing base (47c7f5f) to head (fdfe43d).

Additional details and impacted files
@@                      Coverage Diff                       @@
##           test_branch_intel_tests_debug    #8881   +/-   ##
==============================================================
  Coverage                          90.96%   90.97%           
==============================================================
  Files                                343      343           
  Lines                              21286    21286           
==============================================================
+ Hits                               19363    19364    +1     
+ Misses                              1923     1922    -1     
Flag Coverage Δ
gui-tests 76.21% <ø> (-0.03%) ⬇️
integration-tests 53.42% <ø> (ø)
unit-tests 68.97% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@larsevj larsevj closed this Oct 4, 2024
@larsevj larsevj deleted the debug_intel_failures_before branch October 4, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants