Combine dicts instead of mutating user environment variables

equinor · Oct 23, 2024 · 2c94d39 · 2c94d39
1 parent 5fcf7d3
commit 2c94d39
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/ert/config/ert_config.py b/src/ert/config/ert_config.py
@@ -651,13 +651,13 @@ def forward_model_data_to_json(
         itr: int = 0,
         context_env: Optional[Dict[str, str]] = None,
     ):
-        if context_env is not None:
-            self.env_vars.update(context_env)
+        if context_env is None:
+            context_env = {}
         return self._create_forward_model_json(
             context=self.substitution_list,
             forward_model_steps=self.forward_model_steps,
             user_config_file=self.user_config_file,
-            env_vars=self.env_vars,
+            env_vars={**self.env_vars, **context_env},
             run_id=run_id,
             iens=iens,
             itr=itr,