Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Preload SVGs to improve load times #44

Open
wants to merge 56 commits into
base: main
Choose a base branch
from
Open

WIP: Preload SVGs to improve load times #44

wants to merge 56 commits into from

Conversation

NoraKri
Copy link
Contributor

@NoraKri NoraKri commented Nov 25, 2024 •
edited by azure-boards bot
Loading

AB#201301

Pull requests practices for the SSI team

Aim of the PR

The frontend takes a long time to load. To improve this, we try preloading the SVGs to avoid fetching a file inside each component.

Implementation

  • Pandid.tsx now fetches all SVGs used in the diagram and stores them in a set.
  • All components now lookup their component name in the set and retrieve the SVG.

- Nozzle labels should be fixed before merge

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • This change requires a documentation update

How Has This Been Tested?

  • Visual test that all SVGs are visible.

Additional Changes

  • Small fix: Height has been removed as a parameter from every SVGElement component.

NoraKri and others added 30 commits November 5, 2024 14:48
@NoraKri
set up react project
581d50c
@NoraKri
set up react project
5099c81
@NoraKri
gitignore
e191b28
@NoraKri
react project files
9775313
@NoraKri
display svg
73da9f8
@NoraKri
port most functions to react
a330e29
@NoraKri
Everything except tables ported. Update RunGuide.
5c4b718
@NoraKri
ignore .idea
3144efb
@NoraKri
remove wrongly committed .idea files
be6bb9a
@NoraKri
clean up
490f43d
@NoraKri
idea
46bed2c
@NoraKri
commissioning package is now colored
5054599
@NoraKri
fix piping highlight
e8c71a9
@NoraKri
svg sizing
441dc33
@NoraKri
add style.css
357bacb
@NoraKri
update event listener code
2c35841
@NoraKri
wip
e953cf8
@NoraKri
working wip of equipment rendering without xslt
7b6caf8
@NoraKri
working implementation of pipes, nozzles and equipment
568f6e6
@NoraKri
Most elements implemented, set up app context
5f2122f
@NoraKri
Implement more labels, and some pipe symbols
17bcf31
@NoraKri
Add offPageConnectors
5673dd4
@NoraKri
Merge remote-tracking branch 'origin/main'
0e56e62
@NoraKri
Merge branch 'main' into feat/create-component-from-xml
80429e9 
# Conflicts:
#	www/RunGuide.md
#	xslt/dexpisvg.xslt
@NoraKri
wip docker
b427a5c
@daghovland
Trying to get node docker image to work with demo react setup
a1a9077
@daghovland
Trying node image tutorial setup
d5e4162
@daghovland
Setup from tutorial
bd76e91
@daghovland
Working setup
dd4717e
@daghovland
Using only dockerfile for frontend
ac941d9
NoraKri and others added 26 commits November 21, 2024 16:06
@NoraKri
npm install then npm run dev
d3ff194
@daghovland
Removed user restriction from react docker demo image
f0c1978
@daghovland
Add README about debugging
585c04a
@daghovland
Upgraded to node 23
bca13c7
@daghovland
Ignored copied Origo files
2e14b12
@daghovland
Ignoring generated index files
e4fdd81
@daghovland
Document faster building
c23383c
@NoraKri
add package-lock to git
e884a3c
@NoraKri
react now fetches SVGs locally
4d5e719
@NoraKri
document key change in js script
4d1709a
@NoraKri
a lot of components now use SvgElement
47c63f1
@NoraKri
remove diagram
eb8db89
@NoraKri
remove css
b08c52f
@NoraKri
prevent selection of text when using shift as hotkey
c51ee62
@daghovland
Kopiering av dexpi xml-fil
c2b16c4
@daghovland
Merge remote-tracking branch 'origin/feat/create-component-from-xml' …
c8dbbb2 
…into feat/create-component-from-xml
@henriettelienrebnor
Delete www/RunGuide.md
3481224
@daghovland
Added small file in www/public
234b252
@daghovland
Merge remote-tracking branch 'origin/feat/create-component-from-xml' …
ab1d987 
…into feat/create-component-from-xml
@henriettelienrebnor
Update www/README.md
f7cbfd1
@NoraKri
small fixes
db4fc68
@NoraKri
Merge remote-tracking branch 'origin/feat/create-component-from-xml' …
b7aedfa 
…into feat/create-component-from-xml
@NoraKri
remove height from SVGELement usage, preload SVGs
2d6185b
@NoraKri
remove height from SVGELement usage, preload SVGs
b027e24
@NoraKri
Merge remote-tracking branch 'origin/main'
5a273ae
@NoraKri
Merge branch 'main' into feat/preload-svgs
ee32c16 
# Conflicts:
#	www/src/components/ActuatingSystem.tsx
#	www/src/components/CenterLine.tsx
#	www/src/components/Equipment.tsx
#	www/src/components/NozzleLabel.tsx
#	www/src/components/Pandid.tsx
#	www/src/components/ProcessInstrumentationFunction.tsx
#	www/src/components/SvgElement.tsx
#	www/src/components/piping/PipeSegment.tsx
#	www/src/components/piping/PipeSystem.tsx
#	www/src/components/piping/PipingComponent.tsx
#	www/src/hooks/useSerializeNodeSvg.tsx
#	www/src/hooks/useSerializePipeSvg.tsx
#	www/src/utils/SvgEdit.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NoraKri @daghovland @henriettelienrebnor