Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chex CLI for checking DEXPI P&ID #35

Merged
merged 11 commits into from
Nov 7, 2024
Merged

Conversation

henriettelienrebnor
Copy link
Contributor

@henriettelienrebnor henriettelienrebnor commented Nov 5, 2024

Created the chex CLI , a command-line tool for validating P&ID files with the essential criteria required for the XSLT and RML mappings in this repository.

Also updated one of the rml mappings to be more specific. The only elements we want to check previous / following siblings of are of type Node.

cli/chex/chex.py Outdated Show resolved Hide resolved
cli/chex/chex.py Outdated Show resolved Hide resolved
cli/chex/dexpi.xml Outdated Show resolved Hide resolved
Copy link
Contributor

@markus-ap markus-ap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! A real useful CLI for checking if a DEXPI XML is compliant for the mappings.

Leaving off an approval until the file dexpi.xml has been clarified.

Co-authored-by: Markus Andre Pedersen <[email protected]>
cli/chex/chex.py Outdated Show resolved Hide resolved
Copy link
Contributor

@eoye eoye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, I tested the cli and it works great!🙌 one small comment with just a method name mixup

cli/chex/chex.py Outdated Show resolved Hide resolved
@henriettelienrebnor henriettelienrebnor merged commit d08c99d into main Nov 7, 2024
1 check passed
@eoye eoye deleted the cli-error-checking-dexpi branch November 21, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants