Fix cache publish wheels #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreas-el
force-pushed
the
fix_cache_publish_wheels
branch
15 times, most recently
from
db892ce
to
03b54a8
Compare
yngve-sk
reviewed
Mar 1, 2024
| - uses: actions/checkout@v3 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - uses: actions/cache@v3 | ||
| id: cache-package-check | ||
| with: | ||
| key: carolina_dist_${{ matrix.os }}_python-${{ matrix.python-version }}_boost-${{ inputs.BOOST_VERSION }}_dakota-${{ inputs.DAKOTA_VERSION }} |
There was a problem hiding this comment.
I think this key (and its equivalent at L60) can be renamed to something indicating that is the deps and not dist it represents
There was a problem hiding this comment.
Agreed, this contains deps.
yngve-sk
reviewed
Mar 1, 2024
| if: steps.cache-package-check.outputs.cache-hit != 'true' | ||
| with: | ||
| fetch-depth: 0 | ||
| path: ./dist_build |
There was a problem hiding this comment.
Same for this path, it is deps and not dist I think
There was a problem hiding this comment.
Agreed, this contains deps.
yngve-sk
reviewed
Mar 1, 2024
| make --debug=b -j8 install &> /github/workspace/trace/dakota_install.log | ||
|
|
||
|
|
||
| DIST_BUILD=/github/workspace/dist_build |
There was a problem hiding this comment.
Maybe call it DEPS_BUILD instead of dist, as it is the directory with the dependencies you are copying to the install dir (which is closer to being the dist dir AFAIK)
There was a problem hiding this comment.
Let's do that, this makes sense. Fixing.
yngve-sk
approved these changes
Mar 1, 2024
Feedback from review
andreas-el
force-pushed
the
fix_cache_publish_wheels
branch
from
d2dc3d7
to
386a5c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #95
Separates dependency-building from wheel generation such that we generate new wheels when releasing instead of using the cached ones.
This resolves the bug mentioned above, where caching prohibited the newly tagged release wheels being built.