Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Correct optional parameter syntax in caching code snippet #411

Merged
merged 1 commit into from
Aug 30, 2023
Merged

docs: Correct optional parameter syntax in caching code snippet #411

merged 1 commit into from
Aug 30, 2023

Conversation

MoSattler
Copy link
Contributor

Hi all, I've corrected a minor TypeScript syntax error in the caching.md document regarding the optional timings parameter.

Updated the `getScheduledEvents` function definition in `epic-stack/docs/caching.md` to correctly denote the `timings` parameter as optional.

- Changed `timings: Timings` to `timings?: Timings` to make it valid TypeScript code.

This fix ensures developers referencing the caching documentation will not encounter issues related to this specific code snippet.
@MoSattler MoSattler changed the title fix(docs): Correct optional parameter syntax in caching code snippet docs: Correct optional parameter syntax in caching code snippet Aug 30, 2023
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kentcdodds kentcdodds merged commit 5e1baa7 into epicweb-dev:main Aug 30, 2023
5 checks passed
@MoSattler MoSattler deleted the patch-1 branch August 30, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants