-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add example with fanthom analytics #403
add example with fanthom analytics #403
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! There are a few more things that should probably be handled in your example:
- Update the CSP to support the fathom script: https://github.com/kentcdodds/kentcdodds.com/blob/5dc7a5e6f0561023be3b348c5bf5fd88f3391eb3/server/index.ts#L247
- Handle client-side pageviews: https://github.com/kentcdodds/kentcdodds.com/blob/5dc7a5e6f0561023be3b348c5bf5fd88f3391eb3/app/root.tsx#L384-L419
- Handle pre-fathom-loaded function calls with a fathom queue: https://github.com/kentcdodds/kentcdodds.com/blob/5dc7a5e6f0561023be3b348c5bf5fd88f3391eb3/app/root.tsx#L525-L535
Hope that helps! Thanks for making the example!
made some changes to implement everything but made some modification and would love your feedback again to suit the epic stack to the maximum:
|
063467e
to
4d1f51e
Compare
Looking great. I love the improvements! I left a couple comments. |
made it work with a proxy and also changed the not sure how I feel about it when I feel like this is fine. it's a lot of complexity added for little benefits but I will let you be the judge. if there is any other way you have in mind, would take it. I made a separate PR to easily compare the two options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! Once you merge that proxy solution then I'll merge this 👍👍 Thanks a lot! I think we'll probably bring this into the core eventually.
updated 👌 |
Thanks! |
simple fanthom analytics example via CDN, would love feedback if there is stuff missing on this. i'm currently implementing this on my project so any improvement would be greatly appreciated
Test Plan
Checklist
Screenshots