Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1033 CDXML: expanded abbreviation opens as contracted from .cdxm files #1209

Conversation

ghost
Copy link

@ghost ghost commented Aug 2, 2023

No description provided.

@ghost ghost requested review from even1024 and AliaksandrDziarkach August 2, 2023 15:22
@ghost ghost self-assigned this Aug 2, 2023
@ghost ghost linked an issue Aug 2, 2023 that may be closed by this pull request
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you have to add corresponding out file api/tests/integration/ref/formats/cdxml_ket_expanded.py.out

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added contracted_expanded_structures.ket file as an expected result of test purposes. Is it okay?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No you should provide reference output file.
just do "python api/tests/integration/tests/formats/cdxml_ket_expanded.py > api/tests/integration/ref/formats/cdxml_ket_expanded.py.out"
You can check result of integration test by
python api/tests/integration/test.py -t 1 -p cdxml_ket_expanded.py
Now it return "formats/cdxml_ket_expanded.py........................................[NEW] 0.01 sec" (see "Test" at https://github.com/epam/Indigo/actions/runs/5749220886/job/15584133387?pr=1209)
But should return "formats/cdxml_ket_expanded.py........................................[PASSED] 0.01 sec

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@ghost ghost requested a review from AliaksandrDziarkach August 4, 2023 10:44
Copy link
Collaborator

@AliaksandrDziarkach AliaksandrDziarkach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 94f3e54 into master Aug 7, 2023
@ghost ghost deleted the bugfix/1033-cdxml-expanded-abbreviation-opens-as-contracted-from-cdxm-files branch August 7, 2023 08:44
even1024 added a commit that referenced this pull request Aug 21, 2023
even1024 added a commit that referenced this pull request Aug 21, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CDXML: expanded abbreviation opens as contracted from .cdxm files
2 participants