-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1033 CDXML: expanded abbreviation opens as contracted from .cdxm files #1209
#1033 CDXML: expanded abbreviation opens as contracted from .cdxm files #1209
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you have to add corresponding out file api/tests/integration/ref/formats/cdxml_ket_expanded.py.out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added contracted_expanded_structures.ket file as an expected result of test purposes. Is it okay?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No you should provide reference output file.
just do "python api/tests/integration/tests/formats/cdxml_ket_expanded.py > api/tests/integration/ref/formats/cdxml_ket_expanded.py.out"
You can check result of integration test by
python api/tests/integration/test.py -t 1 -p cdxml_ket_expanded.py
Now it return "formats/cdxml_ket_expanded.py........................................[NEW] 0.01 sec" (see "Test" at https://github.com/epam/Indigo/actions/runs/5749220886/job/15584133387?pr=1209)
But should return "formats/cdxml_ket_expanded.py........................................[PASSED] 0.01 sec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.