Skip to content

Commit

Permalink
🐛 fix(README.md): add solution to known issue with yarn workspace
Browse files Browse the repository at this point in the history
🚀 fix(package.json): update project name to "eonian" to fix yarn workspace error
The project name has been updated to "eonian" to fix yarnpkg/yarn#7734. Also add dependencies that create conflicts:
- "glob": "^8.0.1"
- "yargs": "^17.6.2"
- "graphql": "^16.6.0"
- "@apollo/server": "^4.6.0"
- "@types/node": "^18.15.11"

🔧 feature(web): use type module for package json and fix PostCSS and Prettier configuration files to work with them
  • Loading branch information
LeoVS09 committed Apr 6, 2023
1 parent c6d2b66 commit a43b4fa
Show file tree
Hide file tree
Showing 7 changed files with 1,140 additions and 95 deletions.
11 changes: 11 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,17 @@ yarn
* `yarn test:contracts` - Test only contracts
* `dev:contracts` - Set up a development environment for contracts. Watch file changes and rerun tests.

### Known Issues

Fail during installation of dependency in one of the packages.
Example `error An unexpected error occurred: "expected workspace package to exist for \"yargs\"".`

Issue still not fixed by yarn: https://github.com/yarnpkg/yarn/issues/7734.

#### Solution

Go to the root directory and run `yarn workspace [package-name] add ...` to add package. Use `@eonian/web` as package name for web package and `@eonian/contracts` for contracts package.

## Deployment

The deployment process focused on implementing GitOps practices. Basically, it means all master (main) builds go to production directly. For a web application, PRs also deploy to a preview environment.
Expand Down
9 changes: 6 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "root",
"name": "eonian",
"private": true,
"scripts": {
"bootstrap": "lerna bootstrap --use-workspaces",
Expand Down Expand Up @@ -42,7 +42,10 @@
},
"devDependencies": {
"generate-lockfile": "^0.0.12",
"lerna": "^5.1.6",
"nx": "^14.3.6"
"lerna": "^5.1.6"
},
"dependencies": {
"glob": "^8.0.1",
"yargs": "^17.6.2"
}
}
6 changes: 5 additions & 1 deletion packages/web/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
"eslint": "8.30.0",
"eslint-config-next": "13.0.7",
"framer-motion": "^8.1.9",
"graphql": "^16.6.0",
"lodash.debounce": "^4.0.8",
"next": "13.1.6",
"next-seo": "5.15.0",
Expand All @@ -47,6 +48,7 @@
"typescript": "4.9.4"
},
"devDependencies": {
"@apollo/server": "^4.6.0",
"@storybook/addon-essentials": "7.0.0-beta.20",
"@storybook/addon-interactions": "7.0.0-beta.20",
"@storybook/addon-links": "7.0.0-beta.20",
Expand All @@ -58,6 +60,7 @@
"@testing-library/react": "^13.4.0",
"@testing-library/user-event": "^14.4.3",
"@types/lodash.debounce": "^4.0.7",
"@types/node": "^18.15.11",
"@types/testing-library__jest-dom": "^5.14.5",
"concurrently": "^7.6.0",
"eslint-plugin-storybook": "^0.6.8",
Expand All @@ -71,5 +74,6 @@
"serve": "^14.1.2",
"storybook": "7.0.0-beta.20",
"storybook-addon-pseudo-states": "^2.0.0-next.0"
}
},
"type": "module"
}
File renamed without changes.
File renamed without changes.
Loading

0 comments on commit a43b4fa

Please sign in to comment.