Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clang-tidy: fixes some errors #37388

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −6
Open

clang-tidy: fixes some errors #37388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8e6ffb
clang-tidy: fixes some errors in common/router
mathetake Nov 27, 2024
bad7d15
fix
mathetake Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion envoy/config/config_provider_manager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class ConfigProviderManager : public Singleton::Instance {
~NullOptionalArg() override = default;
};

virtual ~ConfigProviderManager() = default;
~ConfigProviderManager() override = default;

/**
* Returns a dynamic ConfigProvider which receives configuration via an xDS API.
Expand Down
2 changes: 1 addition & 1 deletion envoy/network/socket_interface.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#pragma once

#include <stddef.h>
#include <cstddef>

#include "envoy/common/platform.h"
#include "envoy/common/pure.h"
Expand Down
2 changes: 1 addition & 1 deletion envoy/router/route_config_provider_manager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ using RouteConfigProviderManagerSharedPtr = std::shared_ptr<RouteConfigProviderM
class SrdsFactory : public Envoy::Config::UntypedFactory {
public:
// UntypedFactory
virtual std::string category() const override { return "envoy.srds_factory"; }
std::string category() const override { return "envoy.srds_factory"; }
virtual std::unique_ptr<Envoy::Config::ConfigProviderManager>
createScopedRoutesConfigProviderManager(
Server::Configuration::ServerFactoryContext& factory_context,
Expand Down
5 changes: 2 additions & 3 deletions source/common/router/scoped_rds.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,10 +316,9 @@ class ScopedRoutesConfigProviderManagerOptArg
class SrdsFactoryDefault : public SrdsFactory {
public:
// UntypedFactory
virtual std::string name() const override { return "envoy.srds_factory.default"; }
std::string name() const override { return "envoy.srds_factory.default"; }

virtual std::unique_ptr<Envoy::Config::ConfigProviderManager>
createScopedRoutesConfigProviderManager(
std::unique_ptr<Envoy::Config::ConfigProviderManager> createScopedRoutesConfigProviderManager(
Server::Configuration::ServerFactoryContext& factory_context,
RouteConfigProviderManager& route_config_provider_manager) override {
return std::make_unique<Router::ScopedRoutesConfigProviderManager>(
Expand Down
Loading