-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional scripts
section in libraries' config
#11555
Conversation
This change adds a scripts/hooks section to config that allows to specify a list of available scripts for the given library. Scripts are defined in a free-form, meaning that any kind of value can be provided as a value and is parsed as a string. For example, ``` scripts: refresh: - Standard.Base.HTTP.Caches.refresh ```
There is a checklist in this PR (as well as in any other PR) asking for few checks including:
I guess this time, when we design a new API for library writers, we should start by writing the documentation, updating changelog. Etc.
I'd like to see list of use-cases justifying the API decisions first. Really, "freeform"? Why? What are the scripts good for? How can one use them? When they are called? |
This PR unblocks further work that we have discussed internally for the purpose of #11485. Thanks for your feedback. |
@@ -599,7 +600,8 @@ private void createNew( | |||
authors, | |||
nil(), | |||
"", | |||
Option$.MODULE$.empty()); | |||
Option$.MODULE$.empty(), | |||
List$.MODULE$.empty()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can use nil()
helper method (see two lines above)
Please update |
Currently on hold to test an alternative solution #11485 (comment) |
Made obsolete via #11577. We could still revive it, if needed. |
Pull Request Description
This change adds a scripts/hooks section to config that allows to specify a list of available scripts for the given library. Scripts are defined in a free-form, meaning that any kind of value can be provided as a value and is parsed as a string.
For example,
Part of #11485.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.