Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enso should support relative path for files #10622

Closed
jdunkerley opened this issue Jul 22, 2024 · 1 comment · Fixed by #10660
Closed

Enso should support relative path for files #10622

jdunkerley opened this issue Jul 22, 2024 · 1 comment · Fixed by #10660
Assignees
@radeusgd
Labels
-libs Libraries: New libraries to be implemented p-high Should be completed in the next sprint x-new-feature Type: new feature request
Milestone
2024-08 Release

Comments

@jdunkerley
Copy link
Member

jdunkerley commented Jul 22, 2024 •
edited
Loading

File.new supports relative paths. We want these to be relative to the location that the project is in.

Consider data.csv:

  • It should read from the same folder that contains the project folder.
  • If in the cloud, it should read from the cloud drive.
  • If local should read from the local structure (i.e. enso-projects by default).

Users cannot change the working directory, as the exact order of execution is not easy to control in interactive mode.

File.new will need to create a Enso_File if a relative path passed in a cloud project.

Ideally (but not as critically), the working directory of Enso engine would be correct too. Set to the location of the local projects parent folder.
@jdunkerley jdunkerley added p-high Should be completed in the next sprint x-new-feature Type: new feature request -libs Libraries: New libraries to be implemented labels Jul 22, 2024
@jdunkerley jdunkerley added this to the 2024-08 Release milestone Jul 22, 2024
@radeusgd radeusgd moved this from ❓New to 🔧 Implementation in Issues Board Jul 23, 2024
@enso-bot enso-bot bot mentioned this issue Jul 23, 2024
Closed
@radeusgd radeusgd mentioned this issue Jul 24, 2024
Merged
4 tasks
@radeusgd radeusgd moved this from 🔧 Implementation to 👁️ Code review in Issues Board Jul 25, 2024
@enso-bot
Copy link

enso-bot bot commented Jul 25, 2024

Radosław Waśko reports a new STANDUP for yesterday (2024-07-24):

Progress: Working on edge cases. Added tests. Decided to rely on working dir and enforce it by PM/ensoup or write a warning otherwise. It should be finished by 2024-07-24.

Next Day: Next day I will be working on the #9812 task. Prepare the PR for review. Do work on types.

@mergify mergify bot closed this as completed in #10660 Jul 31, 2024
mergify bot pushed a commit that referenced this issue Jul 31, 2024
@radeusgd
Relative paths are relative to current project locally and in Cloud (#…
9b2f611 
…10660)

- Close #10622
- Changes `project-manager` and `ensoup` launcher to run the engine/language-server with working directory set to the directory containing currently running project.
- If the working directory is _not_ "the directory containing currently running project", a warning is written to logs. This can happen if the raw `/bin/enso` engine runner is used in a different directory.
- In the Cloud, the `File.new` interprets relative paths as cloud paths relative to the Cloud directory containing the current project. Absolute paths are unaffected.
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@radeusgd radeusgd

Labels
-libs Libraries: New libraries to be implemented p-high Should be completed in the next sprint x-new-feature Type: new feature request
Projects
Issues Board
Archived in project
Milestone
2024-08 Release
Development

Successfully merging a pull request may close this issue.

Relative paths are relative to current project locally and in Cloud enso-org/enso
2 participants
@radeusgd @jdunkerley