Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative paths are relative to current project locally and in Cloud #10660

Merged
merged 24 commits into from
Jul 31, 2024

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Jul 24, 2024

Pull Request Description

  • Close Enso should support relative path for files #10622
  • Changes project-manager and ensoup launcher to run the engine/language-server with working directory set to the directory containing currently running project.
  • If the working directory is not "the directory containing currently running project", a warning is written to logs. This can happen if the raw /bin/enso engine runner is used in a different directory.
  • In the Cloud, the File.new interprets relative paths as cloud paths relative to the Cloud directory containing the current project. Absolute paths are unaffected.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@radeusgd radeusgd self-assigned this Jul 26, 2024
@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label Jul 31, 2024
@mergify mergify bot merged commit 9b2f611 into develop Jul 31, 2024
42 checks passed
@mergify mergify bot deleted the wip/radeusgd/10622-relative-paths branch July 31, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enso should support relative path for files
4 participants