-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relative paths are relative to current project locally and in Cloud #10660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeusgd
force-pushed
the
wip/radeusgd/10622-relative-paths
branch
from
July 25, 2024 10:57
375c178
to
e8daf01
Compare
radeusgd
requested review from
jdunkerley,
GregoryTravis,
AdRiley,
marthasharkey,
4e6,
JaroslavTulach,
hubertp,
Akirathan and
Frizi
as code owners
July 25, 2024 10:57
Frizi
approved these changes
Jul 26, 2024
JaroslavTulach
approved these changes
Jul 27, 2024
# Conflicts: # CHANGELOG.md
jdunkerley
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
project-manager
andensoup
launcher to run the engine/language-server with working directory set to the directory containing currently running project./bin/enso
engine runner is used in a different directory.File.new
interprets relative paths as cloud paths relative to the Cloud directory containing the current project. Absolute paths are unaffected.Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.