Fix line at the top of text editor #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If rect.size.height (line 323) is not round for example 320.01 sometimes tiny lines appears above editable text (it disappears after few attempts to select text), with round height value problem is not appears. I found it in Seafile iOS client when trying to edit text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fix issue that appears on 5s real device and on simulator too (6 used).
The problem with appearing tiny grey line above the text in text or md file editor.
Problem appears if textChanged method view height is not round.
The fix is simply round value before assign to rect.
Problem is described on screenshots bellow.