Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add cachedimage pulling progress status #400

Closed
wants to merge 33 commits into from

Conversation

aDisplayName
Copy link

@aDisplayName aDisplayName commented Aug 26, 2024

Add following property in CachedImage CRD

  • spec.progress.available
  • spec.progress.total

Upgrade Crd version from kuikv1alpha1 to kuikv1alpha1ext1
Update the status.progress.available in CachedImage CRD every 5 seconds during the image pulling in cachedimage controller

* update release workflow

* format
* Add progress porperty in CachedImage CRD Status

* Update go package name
* Update readme.md

* Update the readme again
* Add callback with progress update

* Only update progress output every 5 seconds

* Fix error

* fix unit test

* Fix unit test
* Add more logs

* Reduce the unit test checking
@aDisplayName
Copy link
Author

aDisplayName commented Aug 26, 2024

The PR is prepared for supporting the feature of #401

@aDisplayName aDisplayName marked this pull request as ready for review August 26, 2024 20:52
@aDisplayName aDisplayName changed the title Add cachedimage pulling progress status feat: Add cachedimage pulling progress status Aug 26, 2024
@paullaffitte
Copy link
Contributor

Thanks for your work! It looks interesting, this feature can be useful indeed. We will discuss soon with the rest of the team if we are interested in merging it. For my part I would do it. However there is a lot of commits and I will have to review all of them, which will take a bit of time so I hope you're not in a hurry 😅

@aDisplayName
Copy link
Author

aDisplayName commented Aug 27, 2024

@paullaffitte , those commits can be grouped to the following three catalogs:

  1. The CRD Change
  2. The change of reference of kuikv1alpha1 to kuikv1alpha1ext1 in all relative area
  3. The controller change in cachedimage_controller.go and registry.go.

If it makes your life easier, I can create a new PR with three consolidated commits.

Before I'm doing that, one decision I would seek from you, are

  • should we change the CRD version v1alpha1 for both cachedImage and repository, or just keep using it?
  • If the decision is to change the CRD version, then which version would you like to be changed to?

Regards

@aDisplayName
Copy link
Author

I'm closing this PR. As I've submitted a new PR #402 with all the clutters removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants