-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add cachedimage pulling progress status #400
Conversation
* update release workflow * format
* Add progress porperty in CachedImage CRD Status * Update go package name
* Update readme.md * Update the readme again
* Add callback with progress update * Only update progress output every 5 seconds * Fix error * fix unit test * Fix unit test
* Add more logs * Reduce the unit test checking
The PR is prepared for supporting the feature of #401 |
Thanks for your work! It looks interesting, this feature can be useful indeed. We will discuss soon with the rest of the team if we are interested in merging it. For my part I would do it. However there is a lot of commits and I will have to review all of them, which will take a bit of time so I hope you're not in a hurry 😅 |
@paullaffitte , those commits can be grouped to the following three catalogs:
If it makes your life easier, I can create a new PR with three consolidated commits. Before I'm doing that, one decision I would seek from you, are
Regards |
I'm closing this PR. As I've submitted a new PR #402 with all the clutters removed. |
Add following property in CachedImage CRD
spec.progress.available
spec.progress.total
Upgrade Crd version from
kuikv1alpha1
tokuikv1alpha1ext1
Update the
status.progress.available
in CachedImage CRD every 5 seconds during the image pulling in cachedimage controller