Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI & linting improvements #7

Merged
merged 6 commits into from
Nov 11, 2024
Merged

CI & linting improvements #7

merged 6 commits into from
Nov 11, 2024

Commits on Nov 11, 2024

  1. README: Consistently wrap at 80 characters 

    Previously, half of the README was wrapped at 80 characters, while the
other half used one long line per paragraph.

It doesn't really matter which style is used; but it's nice to be
consistent.
    @wjt
    wjt committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    145f067 View commit details
    Browse the repository at this point in the history

  2. Add editorconfig file 

    A minimal editorconfig to set the file encoding keeps being added to my
working copy – I think by Godot 4.4-dev3 – so let's commit it, and add
some potentially-useful rules for editing .gd files in external editors.
    @wjt
    wjt committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    046bbf4 View commit details
    Browse the repository at this point in the history

  3. ci: Cancel running workflows if retriggered 

    For rationale, see
<https://turso.tech/blog/simple-trick-to-save-environment-and-money-when-using-github-actions>.

For the linting & formatting action, the concurrency group is set to
contain the PR (if any) and ref otherwise, on the basis that only the
latest push to a PR or branch is interesting.

For the GitHub Pages and Godot Asset Library actions, each run
overwrites the result of any previous run, so the concurrency group is
just the workflow name.
    @wjt
    wjt committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    9c02d40 View commit details
    Browse the repository at this point in the history

  4. pre-commit: Exclude addons from linter & formatter

    @wjt
    wjt committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    44ec2ae View commit details
    Browse the repository at this point in the history

  5. pre-commit: Use release of godot-gdscript-toolkit 

    The change in question was released in 4.3.0, released in August.
    @wjt
    wjt committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    978ee39 View commit details
    Browse the repository at this point in the history

  6. pre-commit: Update hooks version

    @wjt
    wjt committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    e2595cb View commit details
    Browse the repository at this point in the history