Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input for all nodes #31

Merged
merged 2 commits into from
Jun 15, 2024
Merged

Input for all nodes #31

merged 2 commits into from
Jun 15, 2024

Conversation

manuq
Copy link
Contributor

@manuq manuq commented Jun 14, 2024

No description provided.

@manuq manuq requested a review from wnbaum June 14, 2024 18:29
@manuq
Copy link
Contributor Author

manuq commented Jun 14, 2024

Note: this is on top of #30 . It allows things like:
Captura desde 2024-06-14 15-23-05

The list of blocks is overwelming, until we have dropdowns.

wnbaum
wnbaum approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@wnbaum wnbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very cool! All three of the pressed, just_pressed, and just_released will be very useful I'm sure. We can definitely reduce the number of blocks once we have dropdowns.

@manuq
Copy link
Contributor Author

manuq commented Jun 14, 2024

Actually this can be split from the "dehardcode" PR.

@manuq manuq merged commit 38e7406 into main Jun 15, 2024
1 check passed
@manuq manuq deleted the input-for-all-nodes branch June 15, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wnbaum wnbaum wnbaum approved these changes

@dylanmccall dylanmccall Awaiting requested review from dylanmccall

@dbnicholson dbnicholson Awaiting requested review from dbnicholson

@starnight starnight Awaiting requested review from starnight

@wjt wjt Awaiting requested review from wjt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manuq @wnbaum