BlockCanvas: Implement drag & drop the file from resource FileSystem #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This depends on #296. So, set it as draft now. |
|
Here is the demo video: Screencast.From.2024-11-05.16-28-04.mp4 |
starnight
force-pushed
the
T35712-drag-drop-resource-file
branch
from
a5ce51c
to
c838758
Compare
starnight
force-pushed
the
T35712-drag-drop-resource-file
branch
from
c838758
to
d9f104a
Compare
Define the format "{const <parameter name>: <type>}" as constant
parameter value. And, it is a kind of in parameter value, but never
changes.
https://phabricator.endlessm.com/T35712
Have get_resource_block_definition() providing resource block's definition. It uses constant parameter value with key "file_path" to hold the resource file's path information. https://phabricator.endlessm.com/T35712
… dock Dragging the resources from the filesystem dock shows the object's type as "files". So, allow the "files" type in _can_drop_data() and handle it in _drop_data(). Then, implement getting the resource's file path as a Variable block with _drop_files() in detail. And, because Godot allows dragging multiple files at the same time, this implemention parses the "files"' paths, then generates the corresponding block definition with get_resource_block_definition() and sets default "file_path" for each file's path. Besides, to avoid the dropped blocks overlap with each others on the canvas, each block biases its position a little bit automatically. https://phabricator.endlessm.com/T35712
…ile blocks Drag & drop resouce files as blocks into canvas has been implemented. This commit focuses on serializing from the resource file blocks to AST nodes and values. The resource file's path is saved as in the arguments "file_path" feild. So, pass the arguments, which may have "file_path" into get_block_definition() to rebuild resource file's block definition. https://phabricator.endlessm.com/T35712
starnight
force-pushed
the
T35712-drag-drop-resource-file
branch
from
d9f104a
to
714c31f
Compare
|
Here is the latest demo video: Screencast.From.2024-11-19.19-40-13.mp4 |
manuq
approved these changes
Nov 20, 2024
| var block_def := BlockDefinition.new() | ||
|
|
||
| # Block Definition's name cannot work with '.' | ||
| block_def.name = &"get_resource_%s" % file_name.replace(".", "_") |
There was a problem hiding this comment.
I wonder what happens if the file name has a whitespace in it. Is file_name here already escaping it?
| if not block_name.begins_with("get_resource_"): | ||
| return null | ||
|
|
||
| if file_path == "": |
| if file_path == "": | ||
| return null | ||
|
|
||
| var file_name = file_path.get_file() |
There was a problem hiding this comment.
Is there a chance that this string doesn't have a valid file? Eg. what would happen if the user removes the file from the filesystem? In that case what does get_file() return?
|
|
||
| for file_path in resource_files: | ||
| # Prepare a Variable block getting the file's resource path. | ||
| var block_definition = _res_file_block_def(file_path) |
There was a problem hiding this comment.
The function name _res_file_block_def is not self-explanatory. Maybe _get_block_definition_from_resource_file()? Or at least _get_blockdef_from_resource_file()?
By the way, that function is using BlocksCatalog.get_resource_block_definition which is more clear. Maybe the helper function is not needed at all?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dragging the files from resource FileSystem shows the files' type as
"files". So, allow the "files" type in _can_drop_data() and handle it in
_drop_data(). Then, implement getting the files' resource paths as
Variable blocks with _drop_files() in detail.
https://phabricator.endlessm.com/T35712