build(deps-dev): bump chai from 4.5.0 to 5.1.1 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/chai-5.1.1
branch
2 times, most recently
from
49df628
to
9a5a5e3
Compare
Yeah, I came across this the other week... |
This is necessary to update to Chai 5.x which dropped support for being imported into CommonJS code, since ES6 modules are the more modern, standardized module system. This is all mostly boilerplate changes. The one surprising change is that activation.unit.js and ping.unit.js used to require() the module under test inside the describe() callback, rather than at the top level. I can't see that moving it to the top level makes any difference. I think the two modules are wrong to have a top-level `redis` variable that is set by a call to a function because if you call that function twice with two different values you are changing the variable used by the routes returned from the first call. But when they are imported is not relevant; it's the call to the “class” (which in both cases is actually a factory function, and an arrow function at that, not a class in the sense of the `class` keyword or of a prototype-based function called with `new Foo()`) that sets the top-level variable.
Bumps [chai](https://github.com/chaijs/chai) from 4.5.0 to 5.1.1. - [Release notes](https://github.com/chaijs/chai/releases) - [Changelog](https://github.com/chaijs/chai/blob/main/History.md) - [Commits](chaijs/chai@v4.5.0...v5.1.1) --- updated-dependencies: - dependency-name: chai dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
wjt
force-pushed
the
dependabot/npm_and_yarn/chai-5.1.1
branch
from
9a5a5e3
to
c5f582d
Compare
wjt
reviewed
Oct 18, 2024
| @@ -7,14 +7,15 @@ | |||
| // Upstream: https://github.com/mochajs/mocha/issues/185 | |||
| process.env.NODE_ENV = 'test'; | |||
|
|
|||
| const chai = require('chai'); | |||
| const expect = require('chai').expect; | |||
| import { expect } from 'chai'; | |||
There was a problem hiding this comment.
I just saw https://evertpot.com/using-top-level-await-is-bc-break/ which refers to Node growing support for requireing an ES module in some cases. Which, if it works, would make this PR unnecessary.
|
A newer version of chai exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps chai from 4.5.0 to 5.1.1.
Release notes
Sourced from chai's releases.
... (truncated)
Commits
37263c0fix: support some virtual contexts intoThrow(#1609)91e58edCorrect Mocha import instructions (#1611)61159d1build(deps-dev): bump ip from 1.1.8 to 1.1.9 (#1608)8475d2aSet up ESLint for JSDoc comments (#1605)936c0ca5.1.02cf92f5Fix publish script (#1602)1ba37b5Set support in same members (#1583)f224339Assert interface fix (#1601)d504573Implementiterableassertion (#1592)640d932Convert comments in "legal comments" format to jsdoc (#1598)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)