test(supervisors): fix occasional assertion failures and hangs #2431
Conversation
…lly' Ensure proper cleanup in 'test_multiprocess' by wrapping the supervisor shutdown logic in a 'finally' block. This guarantees that the supervisor is properly terminated and all processes are joined, avoiding potential resource leaks or state residuebetween test runs.
|
Now there are two problems, one is that the process hangs when assertion fails(This PR solves), and the second is that it hangs on execution. related: I create a Windows environment, but it's hard to reproduce.🙃 |
A10-second timeout has been added to the subprocess call within the test_multiprocess.py to ensure it does not hang indefinitely in case of failures or slow systems.
|
Ah, It seems to make sense now. Successful cases are all executed for more than 7s, that is, when the ping is executed, the process is really closed, and then the timeout returns false. I add a timeout of 1 second to the assertion here, and the total execution time is more than 3 s, indicating that the ping method is taken here. The same.
|
|
See? No need for retry. 😌👍 Thanks for your time investigating this. 🙏 |
vvanglro
changed the title
| @@ -34,6 +34,7 @@ def new_function(): | |||
| "-c", | |||
| f"from {module} import {name}; {name}.__wrapped__()", | |||
| ], | |||
| timeout=10, | |||
There was a problem hiding this comment.
Oh, this was added earlier when I was investigating why it was hanging. No need for it now, I'll remove it later
- Replace fixed sleep with retry mechanism for process status checks- Enhance test stability by allowing for variable process startup times
Head branch was pushed to by a user without write access
|
Thanks. |
|
We can't control it with precision, so we might as well retry. Just make sure the dead process is eventually started successfully. |
Summary
It's not entirely clear why the assertion fails here.
assert not process.is_alive()Make sure that test resources can be cleaned up anyway.
Checklist