create new folder per dump #75
Conversation
This comment has been minimized.
This comment has been minimized.
|
I like this but can we make it an option "Create directory per dump [Yes/No]"? I'm happy for it to always come under cleanrip-dumps or whatever though, dumping to the root was never a good idea 😂 |
use tabs for indent. use better(?) folder naming and fix directory creation after inserting a new storage device. also check if game dump directory has been previously created, in case the user reuses a storage device when dumping in smaller chunks.
schicho
force-pushed
the
createFolders
branch
from
947b153
to
11e1df7
Compare
|
If I implement an option for it, it would require a lot of checks in the several dumping/writing functions (dump_bca, dump_game, dump_info) to control wether to write to /cleanrip-dumps/ or /cleanrip-dumps/gamename/ . That will result in a lot of duplication and probably does not make the code very readable. You decide. I can implement it, but I don't think it's great that way. As the middle way, I can also just change it to use /cleanrip-dumps/ , which is still an improvment over dumping straight into the root directory. |
|
Can this still be implemented?? |
Reduces the clutter in the root directory and also makes it easier to find the corresponding files.