Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(desktop): mv traffic monitor to viewer #1787

Merged
merged 5 commits into from
Oct 30, 2024
Merged

refactor(desktop): mv traffic monitor to viewer #1787

merged 5 commits into from
Oct 30, 2024

Conversation

ysfscream
Copy link
Member

@ysfscream ysfscream commented Oct 29, 2024

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

The current traffic statistics are placed on the connection details page.

Issue Number

Example: #123

What is the new behavior?

  1. src/components/ConnectionSelect.vue

    • Added new component for connection selection.
  2. src/components/charts/AreaLine.vue

    • Modified to include optional formatter and adjusted theme-based text color.
  3. src/components/widgets/BytesStatistics.vue

    • Removed bytes statistics widget.

Traffic statistics belong to the function of Viewer and are migrated under the Viewer submenu.

image

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to review?

Other information

@ysfscream ysfscream added this to the v1.11.1 milestone Oct 29, 2024
@ysfscream ysfscream self-assigned this Oct 30, 2024
@ysfscream ysfscream added refactor Refactor code or architecture desktop MQTTX Desktop labels Oct 30, 2024
@ysfscream ysfscream marked this pull request as ready for review October 30, 2024 03:17
@Red-Asuka Red-Asuka merged commit 692f464 into main Oct 30, 2024
4 checks passed
@Red-Asuka Red-Asuka deleted the ysf/desktop branch October 30, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop MQTTX Desktop refactor Refactor code or architecture
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants