Refactoring c# projects

[StefH]

• I acknowledge that this PR is not a solution to the Gilded Rose Kata, but an improvement to the template.

Please provide your PR description below this line

• Use file-scoped namespaces everywhere
• Changed csproj files : added RootNamespace
• Removed NUnit/GildedRoseTests/TextTestFixture.cs because the same logic is defined in csharp.NUnit/GildedRose/Program.cs
• Program.cs is the same for both (⭐: actually I think it's even better to only have 1 main GildedRose project which is defined in the NUnit project and referenced in the other xUnit project)
• small changes from GildedRose(IList<Item> Items) to GildedRose(IList<Item> items) and IList<Item> Items; to private readonly IList<Item> _items; to be more conformant with C# .NET coding guidelines.

[codecop]

Added some in line comments. Also please keep formatting changes minimal if possible (unless missing formatting). Thank you

[StefH]

@codecop
Please check the files again if it's ok.

[codecop]

Thank you. Now I see, the original code was already inconsistent. That is a pity. So as background for you, the code should look the same as much as possible for both projects. From what I see here I think project files, GildedRose and Item are identical. Both Program are almost identical besides the missing dynamic days in the second one. While it has not been there if you can please add it to improve the consistency between the versions. Also both Approvaltests should look as similar as possible. Because you have the project open, maybe you can run a diff between both folders to verify my assumption. If all is good, then please squash your changes to one commit. We are nearly there ;-) Thank you for your patience.

[StefH]

@codecop

• I've fixed README.md file
• I've added a README.md file
• removed obsolete global.json file
• I've fixed the dynamic days and the two main projects are now identical. So only 1 main GildedRose project is needed. I can make that change in this PR also if you approve.
• Both Approvaltests look as similar as possible
• I did a diff between the 2 folders
• squash your changes to one commit --> Normally I don't do this, I do this when I merge the PR to master, in that case I use Squash commit, this makes the Git Timeline even cleaner.

My project

This project

[emilybache]

Hi, thanks to both of you for doing this, I'm happy to see these changes. I think I will ask @codecop to take another look and do the merge as he sees fit.