Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

limit max width of tooltips #2426

Merged
merged 1 commit into from
Aug 29, 2023
Merged

limit max width of tooltips #2426

merged 1 commit into from
Aug 29, 2023

Conversation

patricklx
Copy link
Collaborator

Description

limit width of tooltips and clips too long content.
On hover it will show the full string as tooltip, via title attribute

Screenshots

@patricklx patricklx changed the title limit max with of tooltips limit max width of tooltips Jul 8, 2023
@RobbieTheWagner
Copy link
Member

@patricklx can you please give me an example of when this is needed and possibly some before/after screenshots?

@patricklx
Copy link
Collaborator Author

this is to fix this issue: #2425
although it should really be fixed in the other packages.
screenshot, sure. will come shortly

@patricklx
Copy link
Collaborator Author

patricklx commented Jul 10, 2023 •
edited
Loading

before:
screenshot
after:
Screenshot 2023-07-10 141141
Screenshot 2023-07-10 141207

@patricklx
Copy link
Collaborator Author

@RobbieTheWagner ?

@RobbieTheWagner
Copy link
Member

I'm still not sure on whether we want to limit this or not.

@patricklx
Copy link
Collaborator Author

Well, it's at least a bit better UX for this case.
It will only hide it when it exceeds a certain limit and can still be viewed by hovering over it.
It will take some time until we have a way to have a goto source functionality for templates.

@NullVoxPopuli
Copy link
Contributor

what about wrapping the long value?

@patricklx
Copy link
Collaborator Author

That can also be done. Is that preferred @RobbieTheWagner ?

@patricklx
Copy link
Collaborator Author

would like like this:

image

@NullVoxPopuli
Copy link
Contributor

oooo I like that

@RobbieTheWagner
Copy link
Member

Wrapping is definitely preferred here. Are the wrapping changes in?

@patricklx
Copy link
Collaborator Author

Yes

@RobbieTheWagner RobbieTheWagner merged commit 4a5ec59 into emberjs:main Aug 29, 2023
15 checks passed
@patricklx patricklx deleted the patch-6 branch August 29, 2023 15:52
@patricklx patricklx mentioned this pull request Aug 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobbieTheWagner RobbieTheWagner RobbieTheWagner approved these changes

@NullVoxPopuli NullVoxPopuli NullVoxPopuli approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patricklx @RobbieTheWagner @NullVoxPopuli