Skip to content

Commit

Permalink
sshd: remove blacklist call from grace_alarm_timer
Browse files Browse the repository at this point in the history
Under certain circumstances it may call log(3), which is not async-
signal-safe.

For now just remove the blacklist integration from this path, which
means that blacklistd will not detect and firewall hosts that establish
a connection but do nothing further.

Sponsored by:	The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D46203
  • Loading branch information
emaste committed Aug 6, 2024
1 parent e4d064e commit 2739a68
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions crypto/openssh/sshd.c
Original file line number Diff line number Diff line change
Expand Up @@ -377,8 +377,6 @@ grace_alarm_handler(int sig)
kill(0, SIGTERM);
}

BLACKLIST_NOTIFY(the_active_state, BLACKLIST_AUTH_FAIL, "ssh");

/* Log error and exit. */
sigdie("Timeout before authentication for %s port %d",
ssh_remote_ipaddr(the_active_state),
Expand Down

0 comments on commit 2739a68

Please sign in to comment.