This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Fixed venv detection on windows, added pyvenv.el detection #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking through the commit history, it's possible this may cause a regression on issue #122. I'll try do some testing and check that that use-case is still supported. I think it might be time for a complete rewrite of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR chiefly fixes virtual environment resolution on Windows. I've also added a check for a virtual environment set with pyvenv.el, which overrides any filesystem-based environment detection. Finally, it rewrites
lsp-python-ms-locate-pythonso that it short-circuits once a suitable environment is found.