Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate language server enum settings as const string choices #4517

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Generate language server enum settings as const string choices #4517

merged 1 commit into from
Oct 14, 2024

Conversation

asadoll
Copy link
Contributor

@asadoll asadoll commented Jul 30, 2024 •
edited
Loading

Fixes #4515. Relates to this PR on lsp-haskell.

@jcs090218
Copy link
Member

@michaelpj Does this look correct to you? 🤔

@michaelpj
Copy link
Contributor

I'm sorry, I actually know very little about elisp. But it produced good-looking output for lsp-haskell, so I think it's probably good!

@jcs090218
Copy link
Member

I'm sorry, I actually know very little about elisp. But it produced good-looking output for lsp-haskell, so I think it's probably good!

Thanks for the confirmation! I'll merge this now!

@jcs090218 jcs090218 merged commit 900a041 into emacs-lsp:master Oct 14, 2024
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcs090218 jcs090218 jcs090218 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lsp-generate-settings script generates :tag choices which brings about warnings
3 participants
@asadoll @jcs090218 @michaelpj