Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realign options with HLS master branch #174

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

sir4ur0n
Copy link
Contributor

By following the instructions to generate the options, I found many missing options, so here is a PR to realign on HLS master branch.

⚠️ Unlike what the instructions say, I had to also manually change the :group from 'lsp-haskell to 'lsp-haskell-plugins for all these options. Is this normal?

@alanz
Copy link
Contributor

alanz commented Aug 22, 2023

I had to manually change :group too.

@alanz alanz requested a review from michaelpj August 22, 2023 21:54
@michaelpj
Copy link
Collaborator

I'm confused, why is this different to what you just got, Alan?

@alanz
Copy link
Contributor

alanz commented Aug 22, 2023

I think it only shows differences from what is already in the emacs image when you run it.

And it may be that I had a prior attempt at updating it loaded in my machine at the time.

I guess we should do the process with a clean config each time.

@michaelpj
Copy link
Collaborator

Generally we should not be doing this off master, but off the latest release. But I don't think any options have changed, so its probably fine.

@michaelpj michaelpj merged commit d15bbb7 into emacs-lsp:master Aug 23, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants