Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: go install option and extracted prev into agnostic function #139

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AlejandroSuero
Copy link

@AlejandroSuero AlejandroSuero commented May 3, 2024

Motivation

I think if the user, uses go, this installation process could be an option.

Benefits

The go option doesn't need maintainability because uses the latest stable package.

Now with the agnostic, it introduces better support for Windows extraction. Previously it will only use tar as extraction method, but now it uses Expand-Archive which is native in powershell.

Note

release_file_url function now also returns the os in case is needed, like in the agnostic_install_glow function, to decide the output_filename and which command to use.
Instead of having to repeat the os logic (could be extracted in another PR if needed, for better reusability).

Test Results
Starting...
Scheduling: tests//glow/glow_spec.lua

========================================
Testing:        /path/to/nvim_plugins/glow.nvim/tests/glow/glow_spec.lua
Success ||      setup setup with default configs
Success ||      setup setup with custom configs

Success:        2
Failed :        0
Errors :        0
========================================

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant