-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix Sets the requests equals to limits. #57
Conversation
Reviewer's Guide by SourceryThis pull request adds functionality to set CPU limits in the Kubernetes container resources. Tests have been updated to verify that the CPU limits are correctly set to 4 for all executors. Additionally, a JSON comparison test has been commented out. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lvarin - I've reviewed your changes - here's some feedback:
Overall Comments:
- Could you provide more context on the motivation behind this change? The PR title suggests uncertainty about its value.
- Consider keeping or updating the commented-out test case to maintain test coverage.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
@@ -256,7 +257,7 @@ public void fromTesTaskToK8sConfigMap() throws IOException { | |||
|
|||
taskMasterInputJson.extractingJsonPathNumberValue("resources.disk_gb").isEqualTo(100.0); | |||
|
|||
taskMasterInputJson.isEqualToJson(new ClassPathResource("fromTesToK8s/taskmaster_param.json"), JSONCompareMode.NON_EXTENSIBLE); | |||
//taskMasterInputJson.isEqualToJson(new ClassPathResource("fromTesToK8s/taskmaster_param.json"), JSONCompareMode.NON_EXTENSIBLE); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question (testing): Consider re-enabling JSON comparison test
The commented-out JSON comparison test could provide a comprehensive check to ensure the entire JSON structure is as expected. Consider re-enabling it or providing a reason for its removal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for re-enabling the JSON comparison test, @lvarin. This will help ensure that the entire JSON structure is validated comprehensively. If you encounter any issues with this test or need further assistance, feel free to reach out. Great job!
Summary by Sourcery
Set CPU limits in Kubernetes container resources to match CPU requests and update tests to verify this behavior.
Bug Fixes:
Tests: