Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add RPC calls for p2p module and tests for them #52

Merged
merged 20 commits into from
Sep 7, 2023
Merged

feat: add RPC calls for p2p module and tests for them #52

merged 20 commits into from
Sep 7, 2023

Conversation

fl0rek
Copy link
Member

@fl0rek fl0rek commented Sep 6, 2023

No description provided.

oblique
oblique reviewed Sep 6, 2023
View reviewed changes
rpc/Cargo.toml Outdated Show resolved Hide resolved
oblique
oblique requested changes Sep 6, 2023
View reviewed changes
rpc/Cargo.toml Outdated Show resolved Hide resolved
rpc/src/p2p.rs Outdated Show resolved Hide resolved
rpc/src/p2p.rs Outdated Show resolved Hide resolved
rpc/src/p2p.rs Outdated Show resolved Hide resolved
rpc/src/p2p.rs Outdated Show resolved Hide resolved
rpc/tests/p2p.rs Outdated Show resolved Hide resolved
rpc/tests/p2p.rs Outdated Show resolved Hide resolved
rpc/tests/p2p.rs Show resolved Hide resolved
rpc/tests/p2p.rs Outdated Show resolved Hide resolved
rpc/tests/utils/tiny_node.rs Outdated Show resolved Hide resolved
zvolin
zvolin reviewed Sep 6, 2023
View reviewed changes
rpc/Cargo.toml Outdated Show resolved Hide resolved
zvolin
zvolin reviewed Sep 6, 2023
View reviewed changes
rpc/Cargo.toml Outdated Show resolved Hide resolved
zvolin
zvolin reviewed Sep 6, 2023
View reviewed changes
rpc/Cargo.toml Outdated Show resolved Hide resolved
zvolin
zvolin reviewed Sep 6, 2023
View reviewed changes
rpc/Cargo.toml Outdated Show resolved Hide resolved
@zvolin
Copy link
Member

zvolin commented Sep 6, 2023

sry, haven't refreshed for a while, please ignore previous comments as they seem already adressed

zvolin
zvolin reviewed Sep 6, 2023
View reviewed changes
rpc/tests/p2p.rs Outdated Show resolved Hide resolved
zvolin
zvolin reviewed Sep 6, 2023
View reviewed changes
rpc/tests/p2p.rs Outdated Show resolved Hide resolved
zvolin
zvolin reviewed Sep 6, 2023
View reviewed changes
rpc/src/p2p.rs Outdated Show resolved Hide resolved
zvolin
zvolin reviewed Sep 6, 2023
View reviewed changes
rpc/src/p2p.rs Show resolved Hide resolved
zvolin
zvolin reviewed Sep 6, 2023
View reviewed changes
rpc/src/p2p.rs Show resolved Hide resolved
zvolin
zvolin reviewed Sep 6, 2023
View reviewed changes
rpc/tests/utils/tiny_node.rs Outdated Show resolved Hide resolved
zvolin
zvolin reviewed Sep 6, 2023
View reviewed changes
rpc/tests/utils/tiny_node.rs Outdated Show resolved Hide resolved
zvolin
zvolin reviewed Sep 6, 2023
View reviewed changes
types/Cargo.toml Outdated Show resolved Hide resolved
zvolin
zvolin reviewed Sep 6, 2023
View reviewed changes
types/src/p2p.rs Outdated Show resolved Hide resolved
zvolin
zvolin reviewed Sep 6, 2023
View reviewed changes
types/src/p2p.rs Outdated Show resolved Hide resolved
zvolin
zvolin reviewed Sep 6, 2023
View reviewed changes
rpc/tests/utils/tiny_node.rs Outdated Show resolved Hide resolved
oblique
oblique requested changes Sep 7, 2023
View reviewed changes
rpc/Cargo.toml Outdated Show resolved Hide resolved
rpc/tests/p2p.rs Outdated Show resolved Hide resolved
types/Cargo.toml Outdated Show resolved Hide resolved
types/src/p2p.rs Outdated Show resolved Hide resolved
types/src/p2p.rs Outdated Show resolved Hide resolved
oblique
oblique reviewed Sep 7, 2023
View reviewed changes
types/Cargo.toml Outdated Show resolved Hide resolved
oblique
oblique requested changes Sep 7, 2023
View reviewed changes
rpc/src/p2p.rs Show resolved Hide resolved
oblique
oblique reviewed Sep 7, 2023
View reviewed changes
rpc/Cargo.toml Outdated Show resolved Hide resolved
oblique
oblique reviewed Sep 7, 2023
View reviewed changes
rpc/src/p2p.rs Outdated Show resolved Hide resolved
oblique
oblique reviewed Sep 7, 2023
View reviewed changes
rpc/src/p2p.rs Show resolved Hide resolved
oblique
oblique reviewed Sep 7, 2023
View reviewed changes
rpc/Cargo.toml Outdated Show resolved Hide resolved
oblique
oblique approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@oblique oblique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fl0rek @zvolin
Update rpc/tests/p2p.rs
43ce243 
Co-authored-by: Maciej Zwoliński <[email protected]>
zvolin
zvolin approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@zvolin zvolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work 👍

@zvolin zvolin merged commit aa810b7 into eigerco:main Sep 7, 2023
4 checks passed
@zvolin zvolin mentioned this pull request Sep 8, 2023
Closed
@github-actions github-actions bot mentioned this pull request Jan 9, 2024
Closed
@zvolin zvolin mentioned this pull request Jan 12, 2024
Merged
@fl0rek fl0rek deleted the feat/rpc-p2p-calls branch July 22, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvolin zvolin zvolin approved these changes

@oblique oblique oblique approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fl0rek @zvolin @oblique