Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set body parser error to status 400 by default #5262

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Oct 12, 2023

closes #5261

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e6399fa) 99.86% compared to head (3f6bd87) 99.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5262   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files          36       36           
  Lines        3601     3608    +7     
  Branches      516      517    +1     
=======================================
+ Hits         3596     3603    +7     
  Misses          5        5           
Files Coverage Δ
config/config.default.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fengmk2 fengmk2 merged commit 5ac26a3 into master Oct 12, 2023
17 of 18 checks passed
@fengmk2 fengmk2 deleted the set-default-body-parser-error-to-status-400 branch October 12, 2023 16:07
fengmk2 pushed a commit that referenced this pull request Oct 12, 2023
[skip ci]

## [3.17.5](v3.17.4...v3.17.5) (2023-10-12)

### Bug Fixes

* set body parser error to status 400 by default ([#5262](#5262)) ([5ac26a3](5ac26a3))
Copy link
Contributor

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GET 请求带 gzip body 会导致非法异常
2 participants