Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slice.Reverse, slice.Add, arrayList.Add 修改 #242

Merged
merged 11 commits into from
Jan 22, 2024
Merged

slice.Reverse, slice.Add, arrayList.Add 修改 #242

merged 11 commits into from
Jan 22, 2024

Conversation

dxyinme
Copy link
Contributor

@dxyinme dxyinme commented Jan 17, 2024

  1. 增加slice.Reverse对any类型的支持
  2. arrayList的add方法直接使用slice.Add
  3. 让slice.Add可以支持往末尾添加元素

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4628cd1) 95.88% compared to head (319745e) 95.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #242      +/-   ##
==========================================
+ Coverage   95.88%   95.96%   +0.08%     
==========================================
  Files          66       66              
  Lines        3424     3419       -5     
==========================================
- Hits         3283     3281       -2     
+ Misses        108      106       -2     
+ Partials       33       32       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

slice/add.go Show resolved Hide resolved
slice/reverse.go Show resolved Hide resolved
slice/reverse_test.go Show resolved Hide resolved
@longyue0521 longyue0521 self-requested a review January 19, 2024 01:27
longyue0521
longyue0521 previously approved these changes Jan 19, 2024
Copy link
Contributor

@flycash flycash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没有什么问题,我觉得保持 append 语义才是我想要的。

slice/add.go Show resolved Hide resolved
list/array_list.go Outdated Show resolved Hide resolved
@dxyinme dxyinme requested a review from flycash January 22, 2024 11:15
@longyue0521 longyue0521 merged commit 194ef90 into ecodeclub:dev Jan 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants