Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build All Images Workflow #5

Merged
merged 10 commits into from
Feb 8, 2023
Merged

Build All Images Workflow #5

merged 10 commits into from
Feb 8, 2023

Conversation

Trik16
Copy link
Contributor

@Trik16 Trik16 commented Feb 2, 2023

What this PR does

This PR introduces the ability to launch all image builds in the cads-build-farm repository for a release. This will be done by tagging automatically all images with a specific tag input into the github "Run Workflow" dropdown menu for the the build-images.yml workflow.

I've added workflow_run option to allow the workflows to be triggered by build-images.yml workflow.

on:
  workflow_run:
    workflows: 
      - ecmwf-projects/cads-build-farm/build-images.yml
    types: [requested]

@Trik16 Trik16 changed the title on workflow_run trigger option Build All Images Workflow Feb 3, 2023
@Trik16 Trik16 requested a review from alexamici February 3, 2023 14:46
@Trik16
Copy link
Contributor Author

Trik16 commented Feb 6, 2023

@francesconazzaro @alexamici ready to merge. This will build all the images all at once.

@alexamici
Copy link
Member

@Trik16 I don't think the complexity of .github/workflows/build-images.yml is worth it. I would prefer to merge without the status checks. We will need to check in the GitHub Actions tab.

@Trik16
Copy link
Contributor Author

Trik16 commented Feb 7, 2023

@Trik16 I don't think the complexity of .github/workflows/build-images.yml is worth it. I would prefer to merge without the status checks. We will need to check in the GitHub Actions tab.

In the future, we can use that as a condition to automatize processes. For example, I can trigger the job that changes the newTag parameter only if all previous jobs are succeeded. To do that I need to check the status.

@Trik16
Copy link
Contributor Author

Trik16 commented Feb 7, 2023

Maybe I can save that and move in a dedicated [WIP] PR for the future.

@Trik16
Copy link
Contributor Author

Trik16 commented Feb 7, 2023

@Trik16 I don't think the complexity of .github/workflows/build-images.yml is worth it. I would prefer to merge without the status checks. We will need to check in the GitHub Actions tab.

In the future, we can use that as a condition to automatize processes. For example, I can trigger the job that changes the newTag parameter only if all previous jobs are succeeded. To do that I need to check the status.

It could be like this:
https://github.com/ecmwf-projects/cads-deployment/actions/runs/4084885262

@Trik16
Copy link
Contributor Author

Trik16 commented Feb 8, 2023

cURL request removed

@Trik16 Trik16 merged commit ac9d84c into main Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants