-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ [Service Configuration] Service Configurations refactoring #4079
Open
dseurotech
wants to merge
12
commits into
eclipse:develop
Choose a base branch
from
dseurotech:ref-simplify_service_configuration
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
♻️ [Service Configuration] Service Configurations refactoring #4079
dseurotech
wants to merge
12
commits into
eclipse:develop
from
dseurotech:ref-simplify_service_configuration
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dseurotech
force-pushed
the
ref-simplify_service_configuration
branch
from
July 9, 2024 13:23
0bcd81b
to
c3e8953
Compare
dseurotech
force-pushed
the
ref-simplify_service_configuration
branch
2 times, most recently
from
July 12, 2024 08:56
90927fa
to
4390cfb
Compare
dseurotech
force-pushed
the
ref-simplify_service_configuration
branch
2 times, most recently
from
July 23, 2024 15:15
0ee208a
to
e10cf96
Compare
dseurotech
force-pushed
the
ref-simplify_service_configuration
branch
from
July 30, 2024 06:48
e5efd13
to
b59ee70
Compare
Signed-off-by: dseurotech <[email protected]>
…xibility Signed-off-by: dseurotech <[email protected]>
…trieve all of them together later on Signed-off-by: dseurotech <[email protected]>
…o allow them to be ignored (overriding not supported) Signed-off-by: dseurotech <[email protected]>
Signed-off-by: dseurotech <[email protected]>
Signed-off-by: dseurotech <[email protected]>
…n they operate in (but don't use it directly) Signed-off-by: dseurotech <[email protected]>
Signed-off-by: dseurotech <[email protected]>
…curity vulnerability Signed-off-by: dseurotech <[email protected]>
…ture via Optionals instead of null values Signed-off-by: dseurotech <[email protected]>
dseurotech
force-pushed
the
ref-simplify_service_configuration
branch
from
August 1, 2024 07:26
5813eaf
to
6ffd032
Compare
dseurotech
changed the title
🔥 removing split between configuration metadata interfaces and dto
♻️ Service Configurations refactoring
Aug 1, 2024
…ts own class Signed-off-by: dseurotech <[email protected]>
dseurotech
force-pushed
the
ref-simplify_service_configuration
branch
from
August 1, 2024 10:04
6ffd032
to
68817c4
Compare
Coduz
changed the title
♻️ Service Configurations refactoring
♻️ [Service Configuration] Service Configurations refactoring
Aug 1, 2024
dseurotech
force-pushed
the
ref-simplify_service_configuration
branch
from
August 1, 2024 14:30
68d7b12
to
1f3d03e
Compare
Signed-off-by: dseurotech <[email protected]>
dseurotech
force-pushed
the
ref-simplify_service_configuration
branch
from
August 1, 2024 15:35
1f3d03e
to
ccdca43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues the work initiated during the DI introduction, separating the logic of service configuration management into the ServiceConfigurationManager implementations.
This also changes how ServiceConfigurationManagers are wired - managers are no longer annotated with @nAmed but are wired as contributors to a Map, e.g.:
Unfortunately Guice does not support overriding for Map binder entries, therefore each service configuration manager has been isolated in a separate Module wiring file. If you need to change the behaviour of any ServiceConfigurationManager, configure the locator.xml to ignore that full class name (including the package name) and provide a new implementation.
Having all service configuration managers in a map was functional to solve a vulnerability issue present in the Rest Apis, which were instantiating classes based on the name provided by the user. Now the value provided by the user is matched (at the string level) with the list of available keys.
Furthermore, within this PR the logic to retrieve the TMetadata for services has been isolated in its own provider, allowing for alternative implementations.